Skip to content

Introduce cachedLocalMat and update cloning logic#2612

Merged
yaRnMcDonuts merged 2 commits into
jMonkeyEngine:masterfrom
capdevon:capdevon-SimpleBatchNode
Feb 15, 2026
Merged

Introduce cachedLocalMat and update cloning logic#2612
yaRnMcDonuts merged 2 commits into
jMonkeyEngine:masterfrom
capdevon:capdevon-SimpleBatchNode

Conversation

@capdevon

Copy link
Copy Markdown
Contributor

Added a cachedLocalMat field and updated cloneFields method.

Added a cachedLocalMat field and updated cloneFields method.
@github-actions

Copy link
Copy Markdown

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

  • Go to the (failed run) > Summary > Artifacts > screenshot-test-report
  • Download the zip and open jme3-screenshot-tests/build/reports/ScreenshotDiffReport.html

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

@yaRnMcDonuts yaRnMcDonuts linked an issue Feb 12, 2026 that may be closed by this pull request
@yaRnMcDonuts yaRnMcDonuts added this to the v3.10.0 milestone Feb 12, 2026

@riccardobl riccardobl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disregard my previous message, good catch

@yaRnMcDonuts yaRnMcDonuts merged commit e319e2f into jMonkeyEngine:master Feb 15, 2026
17 checks passed
@capdevon capdevon deleted the capdevon-SimpleBatchNode branch February 15, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleBatchNode does not clone cachedLocalMat in cloneFields

3 participants