Skip to content

CompareScreenshotTest: mitigate a race condition causing tests to fail #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riccardobl merged 2 commits into from
Mar 18, 2026
Merged

CompareScreenshotTest: mitigate a race condition causing tests to fail #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9533d7e
CompareScreenshotTest: mitigate a race condition causing tests to fail
stephengold Mar 18, 2026
90a7ee4
replace yield() with sleep() as suggested by Gemini Code Assist
stephengold Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/org/lwjgl/opengl/awt/CompareScreenshotTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,14 @@ public void run() {
BufferedImage background = rbt.createScreenCapture(frameBounds);
// Some Operating Systems have a window open/close animation, so we wait until the screenshot is stable
while (true) {
// Pause at least 500 milliseconds between captures
try {
Thread.sleep(500);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RuntimeException("Thread interrupted during screenshot delay", e);
}

BufferedImage s = rbt.createScreenCapture(frameBounds);
if (new ImageComparison(background, s).compareImages().getDifferencePercent() == 0) {
break;
Expand Down
Loading