Skip to content

Commit b910b4f

Browse files
committed
Performance improvements
1 parent d828886 commit b910b4f

1 file changed

Lines changed: 13 additions & 9 deletions

File tree

build.gradle

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ tasks.register('copyProjectBaseLibraries', Copy) {
316316
from(configurations.optlibs)
317317

318318
include { details ->
319-
def name = details.file.name
319+
def name = details.name
320320
isSource(name) || isJavadoc(name) || isJmeDep(name)
321321
}
322322

@@ -333,7 +333,7 @@ tasks.register('copyProjectLibraries', Copy) {
333333
from(configurations.optlibs)
334334

335335
exclude { details ->
336-
def name = details.file.name
336+
def name = details.name
337337
isSource(name) || isJavadoc(name) || isJmeDep(name)
338338
}
339339

@@ -347,7 +347,7 @@ tasks.register('copyProjectTestData', Copy) {
347347
description = 'Copies jme3 test data'
348348

349349
from(configurations.testdatalibs) {
350-
include { isJmeDep(it.file.name) }
350+
include { isJmeDep(it.name) }
351351
}
352352

353353
into "jme3-project-testdata/release/modules/ext/"
@@ -390,14 +390,14 @@ ext.buildDependencyResolver = { configs ->
390390
def artifactsByComponent = allArtifacts.groupBy { it.id.componentIdentifier }
391391

392392
def collectTree
393-
collectTree = { component, visited ->
393+
collectTree = { component, visited, result ->
394394
if (!visited.add(component.id)) return []
395395

396-
def result = [component]
396+
result.add(component)
397397

398398
component.dependencies.each { d ->
399399
if (d instanceof ResolvedDependencyResult) {
400-
result += collectTree(d.selected, visited)
400+
collectTree(d.selected, visited, result)
401401
}
402402
}
403403

@@ -409,7 +409,8 @@ ext.buildDependencyResolver = { configs ->
409409
def rootComponent = rootDepsByKey[key]
410410
if (!rootComponent) return []
411411

412-
def components = collectTree(rootComponent, new HashSet())
412+
def components = []
413+
collectTree(rootComponent, new HashSet(), components)
413414

414415
components.collectMany { comp ->
415416
artifactsByComponent[comp.id] ?: []
@@ -435,14 +436,17 @@ tasks.register('createProjectXml') {
435436

436437
deps.each { dep ->
437438

439+
def artifacts = resolveClosure(dep)
440+
if (artifacts.isEmpty()) {
441+
return
442+
}
443+
438444
def name = dep.name
439445
if (j2seLibraries.contains(name + ".xml")) {
440446
return;
441447
}
442448
j2seLibraries.add(name + ".xml")
443449

444-
def artifacts = resolveClosure(dep)
445-
446450
def jmeJarFiles = [] // jme3 jar files
447451
def jmeSourceFiles = [] // jme3 sources
448452
def jmeJavadocFiles = [] // jme3 javadoc

0 commit comments

Comments
 (0)