Skip to content

Commit 87fca05

Browse files
author
farshield
committed
Fix default resampling quality selection
When the user doesn't explicitly specify the resampling quality using the `-Q` flag, the quality should be calculated based on Jack's server sampling rate. This isn't the case, because the `rqual` variable is always set to 16 in `jack_initialize`. This results in the quality always being 16. To fix this and make the behavior the same as the `zita-ajbridge` tools, the redundant `rqual` clamping of the value to the range `[16,96]` should be removed from `jack_initialize()`, because this is done later in `jack_initialize_part2()` only AFTER the quality calculation.
1 parent 767acf0 commit 87fca05

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

tools/zalsa/zita-a2j.cc

-2
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,6 @@ class zita_a2j
287287
delete this;
288288
return 1;
289289
}
290-
if (rqual < 16) rqual = 16;
291-
if (rqual > 96) rqual = 96;
292290
if ((fsamp < 8000) || (bsize < 16) || (nfrag < 2) || (nchan < 1))
293291
{
294292
jack_error (APPNAME ": Illegal parameter value(s).");

tools/zalsa/zita-j2a.cc

-2
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,6 @@ class zita_j2a
285285
delete this;
286286
return 1;
287287
}
288-
if (rqual < 16) rqual = 16;
289-
if (rqual > 96) rqual = 96;
290288
if ((fsamp < 8000) || (bsize < 16) || (nfrag < 2) || (nchan < 1))
291289
{
292290
jack_error (APPNAME ": Illegal parameter value(s).");

0 commit comments

Comments
 (0)