Merge pull request #2590 from cbandy/trace-exec-err

jackc · web-flow · commit 00b606deb49b · 2026-06-30T17:57:30.000-05:00
Call TraceQueryEnd during Exec errors
diff --git a/conn.go b/conn.go
@@ -475,6 +475,9 @@ func (c *Conn) Exec(ctx context.Context, sql string, arguments ...any) (pgconn.C
 	}
 
 	if err := c.deallocateInvalidatedCachedStatements(ctx); err != nil {
+		if c.queryTracer != nil {
+			c.queryTracer.TraceQueryEnd(ctx, c, TraceQueryEndData{Err: err})
+		}
 		return pgconn.CommandTag{}, err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -475,6 +475,9 @@ func (c *Conn) Exec(ctx context.Context, sql string, arguments ...any) (pgconn.C`
`475`	`475`	`}`
`476`	`476`
`477`	`477`	`if err := c.deallocateInvalidatedCachedStatements(ctx); err != nil {`
	`478`	`+ if c.queryTracer != nil {`
	`479`	`+ c.queryTracer.TraceQueryEnd(ctx, c, TraceQueryEndData{Err: err})`
	`480`	`+ }`
`478`	`481`	`return pgconn.CommandTag{}, err`
`479`	`482`	`}`
`480`	`483`