Merge pull request #2592 from greymoth-jp/fix-interval-text-panic

fix(pgtype): return error instead of panicking on malformed interval text

Author: jackc

pgtype/interval.go

@@ -232,7 +232,7 @@ func (scanPlanTextAnyToIntervalScanner) Scan(src []byte, dst any) error {
 		}
 
 		var negative bool
-		if timeParts[0][0] == '-' {
+		if len(timeParts[0]) > 0 && timeParts[0][0] == '-' {
 			negative = true
 			timeParts[0] = timeParts[0][1:]
 		}

pgtype/interval_malformed_test.go

@@ -0,0 +1,19 @@
+package pgtype_test
+
+import (
+	"testing"
+
+	"github.com/jackc/pgx/v5/pgtype"
+)
+
+// A malformed interval whose time component has an empty hours segment
+// (for example ":05:06") must return an error instead of panicking with an
+// index out of range on timeParts[0][0].
+func TestIntervalScanMalformedTimeReturnsError(t *testing.T) {
+	for _, src := range []string{":05:06", "1 day :30:00"} {
+		var v pgtype.Interval
+		if err := v.Scan(src); err == nil {
+			t.Errorf("Scan(%q): expected error, got nil", src)
+		}
+	}
+}