Use underscores in numeric literals for improved readability

#2429

Author: jackc

bench_test.go

@@ -641,35 +641,35 @@ func BenchmarkWrite100RowsViaCopy(b *testing.B) {
 }
 
 func BenchmarkWrite1000RowsViaInsert(b *testing.B) {
-	benchmarkWriteNRowsViaInsert(b, 1000)
+	benchmarkWriteNRowsViaInsert(b, 1_000)
 }
 
 func BenchmarkWrite1000RowsViaMultiInsert(b *testing.B) {
-	benchmarkWriteNRowsViaMultiInsert(b, 1000)
+	benchmarkWriteNRowsViaMultiInsert(b, 1_000)
 }
 
 func BenchmarkWrite1000RowsViaBatchInsert(b *testing.B) {
-	benchmarkWriteNRowsViaBatchInsert(b, 1000)
+	benchmarkWriteNRowsViaBatchInsert(b, 1_000)
 }
 
 func BenchmarkWrite1000RowsViaCopy(b *testing.B) {
-	benchmarkWriteNRowsViaCopy(b, 1000)
+	benchmarkWriteNRowsViaCopy(b, 1_000)
 }
 
 func BenchmarkWrite10000RowsViaInsert(b *testing.B) {
-	benchmarkWriteNRowsViaInsert(b, 10000)
+	benchmarkWriteNRowsViaInsert(b, 10_000)
 }
 
 func BenchmarkWrite10000RowsViaMultiInsert(b *testing.B) {
-	benchmarkWriteNRowsViaMultiInsert(b, 10000)
+	benchmarkWriteNRowsViaMultiInsert(b, 10_000)
 }
 
 func BenchmarkWrite10000RowsViaBatchInsert(b *testing.B) {
-	benchmarkWriteNRowsViaBatchInsert(b, 10000)
+	benchmarkWriteNRowsViaBatchInsert(b, 10_000)
 }
 
 func BenchmarkWrite10000RowsViaCopy(b *testing.B) {
-	benchmarkWriteNRowsViaCopy(b, 10000)
+	benchmarkWriteNRowsViaCopy(b, 10_000)
 }
 
 func BenchmarkMultipleQueriesNonBatchNoStatementCache(b *testing.B) {

conn_test.go

@@ -795,7 +795,7 @@ func TestListenNotifyWhileBusyIsSafe(t *testing.T) {
 
 		<-listening
 
-		for range 100000 {
+		for range 100_000 {
 			mustExec(t, conn, "notify busysafe, 'hello'")
 		}
 	}()

copy_from_test.go

@@ -283,7 +283,7 @@ func TestConnCopyFromLarge(t *testing.T) {
 
 	inputRows := [][]any{}
 
-	for range 10000 {
+	for range 10_000 {
 		inputRows = append(inputRows, []any{int16(0), int32(1), int64(2), "abc", "efg", time.Date(2000, 1, 1, 0, 0, 0, 0, time.UTC), tzedTime, []byte{111, 111, 111, 111}})
 	}
 
@@ -467,7 +467,7 @@ func (cfs *clientFailSource) Values() ([]any, error) {
 		cfs.err = fmt.Errorf("client error")
 		return nil, cfs.err
 	}
-	return []any{make([]byte, 100000)}, nil
+	return []any{make([]byte, 100_000)}, nil
 }
 
 func (cfs *clientFailSource) Err() error {
@@ -546,7 +546,7 @@ func (fs *failSource) Values() ([]any, error) {
 	if fs.count == 3 {
 		return []any{nil}, nil
 	}
-	return []any{make([]byte, 100000)}, nil
+	return []any{make([]byte, 100_000)}, nil
 }
 
 func (fs *failSource) Err() error {
@@ -717,7 +717,7 @@ func (cfs *clientFinalErrSource) Next() bool {
 }
 
 func (cfs *clientFinalErrSource) Values() ([]any, error) {
-	return []any{make([]byte, 100000)}, nil
+	return []any{make([]byte, 100_000)}, nil
 }
 
 func (cfs *clientFinalErrSource) Err() error {

internal/iobufpool/iobufpool_test.go

@@ -71,7 +71,7 @@ func TestPutHandlesWrongSizedBuffers(t *testing.T) {
 func TestPutGetBufferReuse(t *testing.T) {
 	// There is no way to guarantee a buffer will be reused. It should be, but a GC between the Put and the Get will cause
 	// it not to be. So try many times.
-	for range 100000 {
+	for range 100_000 {
 		buf := iobufpool.Get(4)
 		(*buf)[0] = 1
 		iobufpool.Put(buf)

pgconn/ctxwatch/context_watcher_test.go

@@ -112,7 +112,7 @@ func TestContextWatcherStress(t *testing.T) {
 		},
 	})
 
-	cycleCount := 100000
+	cycleCount := 100_000
 
 	for i := range cycleCount {
 		ctx, cancel := context.WithCancel(context.Background())

pgconn/pgconn_stress_test.go

@@ -18,7 +18,7 @@ func TestConnStress(t *testing.T) {
 	require.NoError(t, err)
 	defer closeConn(t, pgConn)
 
-	actionCount := 10000
+	actionCount := 10_000
 	if s := os.Getenv("PGX_TEST_STRESS_FACTOR"); s != "" {
 		stressFactor, err := strconv.ParseInt(s, 10, 64)
 		require.Nil(t, err, "Failed to parse PGX_TEST_STRESS_FACTOR")

pgconn/pgconn_test.go

@@ -1600,7 +1600,7 @@ func TestConnExecBatchHuge(t *testing.T) {
 
 	batch := &pgconn.Batch{}
 
-	queryCount := 100000
+	queryCount := 100_000
 	args := make([]string, queryCount)
 
 	for i := range args {
@@ -2110,7 +2110,7 @@ func TestConnCopyFromCanceled(t *testing.T) {
 
 	r, w := io.Pipe()
 	go func() {
-		for i := range 1000000 {
+		for i := range 1_000_000 {
 			a := strconv.Itoa(i)
 			b := "foo " + a + " bar"
 			_, err := w.Write(fmt.Appendf(nil, "%s,\"%s\"\n", a, b))
@@ -2157,7 +2157,7 @@ func TestConnCopyFromPrecanceled(t *testing.T) {
 
 	r, w := io.Pipe()
 	go func() {
-		for i := range 1000000 {
+		for i := range 1_000_000 {
 			a := strconv.Itoa(i)
 			b := "foo " + a + " bar"
 			_, err := w.Write(fmt.Appendf(nil, "%s,\"%s\"\n", a, b))

pgproto3/backend.go

@@ -46,8 +46,8 @@ type Backend struct {
 }
 
 const (
-	minStartupPacketLen = 4     // minStartupPacketLen is a single 32-bit int version or code.
-	maxStartupPacketLen = 10000 // maxStartupPacketLen is MAX_STARTUP_PACKET_LENGTH from PG source.
+	minStartupPacketLen = 4      // minStartupPacketLen is a single 32-bit int version or code.
+	maxStartupPacketLen = 10_000 // maxStartupPacketLen is MAX_STARTUP_PACKET_LENGTH from PG source.
 )
 
 // NewBackend creates a new Backend.

pgproto3/chunkreader_test.go

@@ -65,7 +65,7 @@ func TestChunkReaderNextFuzz(t *testing.T) {
 
 	randomSizes := rand.New(rand.NewPCG(0, 0))
 
-	for range 100000 {
+	for range 100_000 {
 		size := randomSizes.IntN(16384) + 1
 		buf, err := r.Next(size)
 		if err != nil {

pgtype/interval.go

@@ -11,7 +11,7 @@ import (
 )
 
 const (
-	microsecondsPerSecond = 1000000
+	microsecondsPerSecond = 1_000_000
 	microsecondsPerMinute = 60 * microsecondsPerSecond
 	microsecondsPerHour   = 60 * microsecondsPerMinute
 	microsecondsPerDay    = 24 * microsecondsPerHour