Skip to content

Commit fce1a04

Browse files
committed
passing err by value
1 parent e04a6de commit fce1a04

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

batch.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ func (br *batchResults) Close() error {
221221
br.endTraced = true
222222
}
223223

224-
invalidateCachesOnBatchResultsError(br.conn, br.b, &br.err)
224+
invalidateCachesOnBatchResultsError(br.conn, br.b, br.err)
225225
}()
226226

227227
if br.err != nil {
@@ -394,7 +394,7 @@ func (br *pipelineBatchResults) Close() error {
394394
br.endTraced = true
395395
}
396396

397-
invalidateCachesOnBatchResultsError(br.conn, br.b, &br.err)
397+
invalidateCachesOnBatchResultsError(br.conn, br.b, br.err)
398398
}()
399399

400400
if br.err == nil && br.lastRows != nil && br.lastRows.err != nil {
@@ -447,8 +447,8 @@ func (br *pipelineBatchResults) nextQueryAndArgs() (query string, args []any, er
447447
}
448448

449449
// invalidates statement and description caches on batch results error
450-
func invalidateCachesOnBatchResultsError(conn *Conn, b *Batch, err *error) {
451-
if err != nil && *err != nil && conn != nil && b != nil {
450+
func invalidateCachesOnBatchResultsError(conn *Conn, b *Batch, err error) {
451+
if err != nil && conn != nil && b != nil {
452452
if sc := conn.statementCache; sc != nil {
453453
for _, bi := range b.QueuedQueries {
454454
sc.Invalidate(bi.SQL)

0 commit comments

Comments
 (0)