ctxwatch: ContextWatcher goroutine leak#2515
Merged
Merged
Conversation
This fixes a goroutine leak that could occur if Unwatch was deferred a long time or was not called. The mechanism now uses `context.AfterFunc` and a channel close, rather than a channel send+receive and boolean flags. Closes: jackc#1999 Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Owner
|
Thanks. LGTM. I was concerned about this simply masking a missing Unwatch call so I did a little investigating and found a couple potential paths which I fixed with a subsequent commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a goroutine leak that could occur if Unwatch was deferred a long time or was not called.
The mechanism now uses
context.AfterFuncand a channel close, rather than a channel send+receive and boolean flags.Closes: #1999