Skip to content

Targeted suggestion suppression #436

Open
@jackfirth

Description

@jackfirth

Sometimes a suggestion from Resyntax makes sense generally, but is unhelpful in a specific context. See this comment for an example. Currently, this situation requires users to repeatedly ignore Autofixer pull requests that try to fix the issue they don't care about. Usually in this situation I prefer to just get rid of the suggestion entirely, or otherwise rework it so that it only targets the high-value cases. I don't see a way to do that with the linked issue, since it's very dependent on the surrounding context.

As a last resort, Resyntax may need to provide a way to handle these sorts of issues. I can think of a few approaches:

  • Make the autofixer somehow magically "just know" that a suggestion shouldn't be made because it's been made before and was disregarded.
  • Add a way to annotate code that suppresses refactoring rules for that code alone, e.g. (resyntax-suppress zero-comparison-to-positive? (some-code ...)).
  • Add a way to annotate packages or collections to suppress refactoring rules for that entire package or collection, e.g. in an info.rkt file.
  • Add a way for refactoring rules to inspect their surrounding context, so that the zero-comparison-to-positive? rule can see that a > or < form is being used alongside a = form like in the example from the comment above. Then that rule could silence itself in cases where it would break "visual symmetry".

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestexisting lintIssues or pull requests relating to existing lints

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions