name on signups

Author: jackharrhy

cli.py

@@ -262,7 +262,7 @@ def signups():
     conn = duckdb.connect(str(db_path), read_only=True)
     rows = conn.execute(
         """
-        SELECT id, timestamp, email, notify_plow, notify_projects,
+        SELECT id, timestamp, name, email, notify_plow, notify_projects,
                notify_siliconharbour, note, ip, user_agent
         FROM signups
         ORDER BY timestamp DESC
@@ -271,6 +271,7 @@ def signups():
     columns = [
         "id",
         "timestamp",
+        "name",
         "email",
         "notify_plow",
         "notify_projects",
@@ -327,10 +328,11 @@ def _bool_badge(val):
                 f"</div>"
             )
 
+        name_str = _esc(r["name"]) if r["name"] else ""
         cards_html.append(f"""\
 <div class="card">
   <div class="card-header">
-    <span class="email">{_esc(r["email"])}</span>
+    <span class="email">{name_str + " &lt;" + _esc(r["email"]) + "&gt;" if name_str else _esc(r["email"])}</span>
     <span class="id">#{r["id"]}</span>
   </div>
   <div class="meta">

src/where_the_plow/db.py

@@ -453,6 +453,7 @@ def insert_viewport(
     def insert_signup(
         self,
         email: str,
+        name: str,
         ip: str | None = None,
         user_agent: str | None = None,
         notify_plow: bool = False,
@@ -463,11 +464,12 @@ def insert_signup(
         """Record an email signup."""
         self._cursor().execute(
             """
-            INSERT INTO signups (email, ip, user_agent, notify_plow, notify_projects, notify_siliconharbour, note)
-            VALUES (?, ?, ?, ?, ?, ?, ?)
+            INSERT INTO signups (email, name, ip, user_agent, notify_plow, notify_projects, notify_siliconharbour, note)
+            VALUES (?, ?, ?, ?, ?, ?, ?, ?)
             """,
             [
                 email,
+                name,
                 ip,
                 user_agent,
                 notify_plow,

src/where_the_plow/migrations/003_add_signup_name.py

@@ -0,0 +1,48 @@
+"""Add name column to signups table.
+
+Stores the user's name alongside their email. NOT NULL with DEFAULT ''
+so existing rows get an empty string.
+
+DuckDB doesn't support ALTER TABLE ADD COLUMN with constraints, so we
+recreate the table (same pattern as migration 002).
+"""
+
+import duckdb
+
+
+def _has_column(conn: duckdb.DuckDBPyConnection, table: str, column: str) -> bool:
+    rows = conn.execute(
+        "SELECT column_name FROM information_schema.columns "
+        "WHERE table_name=? AND column_name=?",
+        [table, column],
+    ).fetchall()
+    return len(rows) > 0
+
+
+def upgrade(conn: duckdb.DuckDBPyConnection) -> None:
+    if not _has_column(conn, "signups", "name"):
+        conn.execute("CREATE SEQUENCE IF NOT EXISTS signups_mig_seq")
+        conn.execute("""
+            CREATE TABLE signups_new (
+                id              BIGINT DEFAULT nextval('signups_mig_seq') PRIMARY KEY,
+                timestamp       TIMESTAMPTZ NOT NULL DEFAULT now(),
+                name            VARCHAR NOT NULL DEFAULT '',
+                email           VARCHAR NOT NULL,
+                ip              VARCHAR,
+                user_agent      VARCHAR,
+                notify_plow     BOOLEAN NOT NULL DEFAULT FALSE,
+                notify_projects BOOLEAN NOT NULL DEFAULT FALSE,
+                notify_siliconharbour BOOLEAN NOT NULL DEFAULT FALSE,
+                note            VARCHAR
+            )
+        """)
+        conn.execute("""
+            INSERT INTO signups_new
+                (id, timestamp, name, email, ip, user_agent,
+                 notify_plow, notify_projects, notify_siliconharbour, note)
+            SELECT id, timestamp, '', email, ip, user_agent,
+                   notify_plow, notify_projects, notify_siliconharbour, note
+            FROM signups
+        """)
+        conn.execute("DROP TABLE signups")
+        conn.execute("ALTER TABLE signups_new RENAME TO signups")

src/where_the_plow/models.py

@@ -120,6 +120,7 @@ class StatsResponse(BaseModel):
 
 class SignupRequest(BaseModel):
     email: str = Field(..., description="Email address", min_length=3, max_length=320)
+    name: str = Field(..., description="User's name", min_length=1, max_length=200)
     notify_plow: bool = Field(False, description="Notify when plow visits street")
     notify_projects: bool = Field(False, description="Notify about other projects")
     notify_siliconharbour: bool = Field(

src/where_the_plow/routes.py

@@ -430,6 +430,7 @@ def signup(request: Request, body: SignupRequest):
     db = request.app.state.db
     db.insert_signup(
         email=body.email,
+        name=body.name,
         ip=ip,
         user_agent=user_agent,
         notify_plow=body.notify_plow,

src/where_the_plow/static/app.js

@@ -142,6 +142,7 @@ const welcomeCloseBtn = document.getElementById("welcome-close");
 const welcomeDismissBtn = document.getElementById("welcome-dismiss");
 const welcomeCtaBtn = document.getElementById("welcome-cta");
 const signupPanel = document.getElementById("welcome-signup");
+const signupName = document.getElementById("signup-name");
 const signupEmail = document.getElementById("signup-email");
 const signupProjects = document.getElementById("signup-projects");
 const signupSH = document.getElementById("signup-siliconharbour");
@@ -183,7 +184,7 @@ welcomeOverlay.addEventListener("click", (e) => {
 welcomeCtaBtn.addEventListener("click", () => {
   welcomeCtaBtn.style.display = "none";
   signupPanel.style.display = "block";
-  signupEmail.focus();
+  signupName.focus();
 });
 
 // Note toggle
@@ -195,6 +196,13 @@ signupNoteToggle.addEventListener("click", () => {
 
 // Submit signup
 signupSubmitBtn.addEventListener("click", async () => {
+  const name = signupName.value.trim();
+  if (!name) {
+    signupStatus.textContent = "Please enter your name.";
+    signupStatus.className = "error";
+    return;
+  }
+
   const email = signupEmail.value.trim();
   if (!email || !email.includes("@")) {
     signupStatus.textContent = "Please enter a valid email address.";
@@ -212,6 +220,7 @@ signupSubmitBtn.addEventListener("click", async () => {
       headers: { "Content-Type": "application/json" },
       body: JSON.stringify({
         email,
+        name,
         notify_plow: true,
         notify_projects: signupProjects.checked,
         notify_siliconharbour: signupSH.checked,
@@ -228,6 +237,7 @@ signupSubmitBtn.addEventListener("click", async () => {
     signupStatus.textContent =
       "You're signed up! I don't have a newsletter system just yet, but when I do, you'll be the first to know!";
     signupStatus.className = "success";
+    signupName.disabled = true;
     signupEmail.disabled = true;
     signupProjects.disabled = true;
     signupSH.disabled = true;

src/where_the_plow/static/index.html

@@ -378,6 +378,12 @@ <h4>About</h4>
                         email, I'll let you know when it, and other new
                         features, are ready.
                     </p>
+                    <input
+                        type="text"
+                        id="signup-name"
+                        placeholder="Your name"
+                        autocomplete="name"
+                    />
                     <input
                         type="email"
                         id="signup-email"

src/where_the_plow/static/style.css

@@ -949,6 +949,7 @@ body.controls-left .maplibregl-ctrl-bottom-right .maplibregl-ctrl {
     font-size: 12px;
 }
 
+#signup-name,
 #signup-email {
     width: 100%;
     padding: 8px 10px;
@@ -962,6 +963,7 @@ body.controls-left .maplibregl-ctrl-bottom-right .maplibregl-ctrl {
     margin-bottom: 8px;
 }
 
+#signup-name:focus,
 #signup-email:focus {
     outline: none;
     border-color: var(--color-accent);

tests/test_migrate.py

@@ -347,6 +347,7 @@ def test_001_fresh_db_creates_tables(tmp_path):
     }
     assert "ip" in su_cols
     assert "user_agent" in su_cols
+    assert "name" in su_cols
 
     conn.close()
 
@@ -373,7 +374,7 @@ def test_002_migrates_prod_db(tmp_path):
     )
     run_migrations(conn, migrations_dir)
 
-    assert get_version(conn) == 2
+    assert get_version(conn) == 3
 
     # Vehicles should have source column with composite PK
     veh_cols = {
@@ -485,7 +486,8 @@ def test_already_migrated_db_gets_stamped(tmp_path):
             notify_plow BOOLEAN NOT NULL DEFAULT FALSE,
             notify_projects BOOLEAN NOT NULL DEFAULT FALSE,
             notify_siliconharbour BOOLEAN NOT NULL DEFAULT FALSE,
-            note VARCHAR
+            note VARCHAR,
+            name VARCHAR NOT NULL DEFAULT ''
         )
     """)
 
@@ -494,6 +496,6 @@ def test_already_migrated_db_gets_stamped(tmp_path):
     )
     run_migrations(conn, migrations_dir)
 
-    # Should be stamped at version 2 with no errors
-    assert get_version(conn) == 2
+    # Should be stamped at version 3 with no errors
+    assert get_version(conn) == 3
     conn.close()