Skip to content

Commit 2e10d52

Browse files
[jaeger] Add appProtocol #539 (#540)
Add appProtocol Signed-off-by: Antonio Berben <antonio.berben@solo.io>
1 parent 3af618d commit 2e10d52

3 files changed

Lines changed: 25 additions & 1 deletion

File tree

charts/jaeger/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ appVersion: 1.53.0
33
description: A Jaeger Helm chart for Kubernetes
44
name: jaeger
55
type: application
6-
version: 1.0.1
6+
version: 1.0.2
77
# CronJobs require v1.21
88
kubeVersion: ">= 1.21-0"
99
keywords:

charts/jaeger/templates/allinone-collector-svc.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,36 @@ spec:
1212
- name: http-zipkin
1313
port: 9411
1414
targetPort: 0
15+
{{- if semverCompare ">=1.20" .Capabilities.KubeVersion.Version }}
16+
appProtocol: http
17+
{{- end }}
1518
- name: grpc-http
1619
port: 14250
1720
targetPort: 0
21+
{{- if semverCompare ">=1.20" .Capabilities.KubeVersion.Version }}
22+
appProtocol: grpc
23+
{{- end }}
1824
- name: c-tchan-trft
1925
port: 14267
2026
targetPort: 0
2127
- name: http-c-binary-trft
2228
port: 14268
2329
targetPort: 0
30+
{{- if semverCompare ">=1.20" .Capabilities.KubeVersion.Version }}
31+
appProtocol: http
32+
{{- end }}
2433
- name: {{ .Values.allInOne.service.collector.otlp.grpc.name }}
2534
port: 4317
2635
targetPort: 0
36+
{{- if semverCompare ">=1.20" .Capabilities.KubeVersion.Version }}
37+
appProtocol: grpc
38+
{{- end }}
2739
- name: {{ .Values.allInOne.service.collector.otlp.http.name }}
2840
port: 4318
2941
targetPort: 0
42+
{{- if semverCompare ">=1.20" .Capabilities.KubeVersion.Version }}
43+
appProtocol: http
44+
{{- end }}
3045
selector:
3146
{{- include "jaeger.selectorLabels" . | nindent 4 }}
3247
app.kubernetes.io/component: all-in-one

charts/jaeger/templates/collector-svc.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,19 @@ spec:
1919
{{- end }}
2020
protocol: TCP
2121
targetPort: grpc
22+
{{- if semverCompare ">=1.20" .Capabilities.KubeVersion.Version }}
23+
appProtocol: grpc
24+
{{- end }}
2225
- name: http
2326
port: {{ .Values.collector.service.http.port }}
2427
{{- if and (eq .Values.collector.service.type "NodePort") (.Values.collector.service.http.nodePort) }}
2528
nodePort: {{ .Values.collector.service.http.nodePort }}
2629
{{- end }}
2730
protocol: TCP
2831
targetPort: http
32+
{{- if semverCompare ">=1.20" .Capabilities.KubeVersion.Version }}
33+
appProtocol: http
34+
{{- end }}
2935
{{- if .Values.collector.service.zipkin }}
3036
- name: zipkin
3137
port: {{ .Values.collector.service.zipkin.port }}
@@ -34,6 +40,9 @@ spec:
3440
{{- end }}
3541
protocol: TCP
3642
targetPort: zipkin
43+
{{- if semverCompare ">=1.20" .Capabilities.KubeVersion.Version }}
44+
appProtocol: http
45+
{{- end }}
3746
{{- end }}
3847
{{- if or .Values.collector.service.otlp.grpc .Values.collector.service.otlp.http }}
3948
- name: {{ .Values.collector.service.otlp.grpc.name }}

0 commit comments

Comments
 (0)