Skip to content

Commit 43f6329

Browse files
Copilotyurishkuro
andauthored
Remove unused curl.image helper template (#716)
Resolves #715 The `curl.image` helper template in `_helpers.tpl` is defined but never referenced anywhere in the chart. Likely a relic from the Bitnami Elasticsearch chart integration. **Changes:** - Removed `curl.image` helper definition from `charts/jaeger/templates/_helpers.tpl` - Bumped chart version from `4.3.0` to `4.3.1` **Verification:** ```bash # No references found in any templates $ grep -r "curl.image" charts/jaeger/templates/ $ grep -r "include.*curl" charts/jaeger/templates/ $ grep -r "curlimages/curl" charts/jaeger/templates/ ``` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `charts.bitnami.com` > - Triggering command: `/usr/local/bin/helm helm dependency update` (dns block) > - `charts.helm.sh` > - Triggering command: `/usr/local/bin/helm helm dependency update` (dns block) > - `helm.elastic.co` > - Triggering command: `/usr/local/bin/helm helm dependency update` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/jaegertracing/helm-charts/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > #715 </details> <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/jaegertracing/helm-charts/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yurishkuro <3523016+yurishkuro@users.noreply.github.com>
1 parent 985d2a9 commit 43f6329

2 files changed

Lines changed: 1 addition & 14 deletions

File tree

charts/jaeger/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ appVersion: 2.14.1
33
description: A Jaeger Helm chart for Kubernetes
44
name: jaeger
55
type: application
6-
version: 4.3.0
6+
version: 4.3.1
77
# CronJobs require v1.21
88
kubeVersion: ">= 1.21-0"
99
keywords:

charts/jaeger/templates/_helpers.tpl

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -449,19 +449,6 @@ Create pull secrets for esLookback image
449449
{{- end }}
450450

451451

452-
{{/*
453-
Define curl image declaration
454-
*/}}
455-
{{- define "curl.image" -}}
456-
{{- $image := "curlimages/curl" -}}
457-
{{- if .Values.global.imageRegistry -}}
458-
{{ .Values.global.imageRegistry }}/{{ $image }}
459-
{{- else -}}
460-
{{ $image }}
461-
{{- end -}}
462-
{{- end -}}
463-
464-
465452
{{- define "jaeger.namespace" -}}
466453
{{- if .Values.namespaceOverride -}}
467454
{{- .Values.namespaceOverride -}}

0 commit comments

Comments
 (0)