Commit f8149de
authored
[jaeger] Add support for podAnnotations to all-in-one deployment (#739)
## Summary
Currently, the `all-in-one` deployment template has a hardcoded
`annotations` block. This prevents users from injecting critical
metadata required by various ecosystem tools that rely on Pod-level
annotations.
### Example Use Cases
* **Consul Service Mesh:** Requires
`consul.hashicorp.com/connect-inject` to inject sidecar proxies for
secure mTLS communication (e.g., securing OTLP traffic on TCP port
4317).
* **Custom Metrics Scrapers:** While Prometheus annotations are
hardcoded, users may have custom scraping requirements or use
alternative observability platforms (like Datadog or New Relic) that
require specific pod-level tags.
### Changes
* This adds the `podAnnotations` field to the jaeger values section and
its usage to the `all-in-one` deployment template.
* Move the default configuration for prometheus scraping setup from the
template to the values.
* Ensured usage of the same pattern as the spark, esIndexCleaner,
esRollover, and esLookback job templates.
* The legacy components such as `query` supported `podAnnotations` the
same way the other components still do.
### Checklist
- [x] helm lint charts/jaeger passes
- [x] helm template renders correctly with default values (no extra
extra annotations on pod level)
- [x] helm template renders correctly with extra annotations set (pod
annotations appear in output)
- [x] CI values files render cleanly
Signed-off-by: Michael Jung <mike_jung@gmx.net>1 parent 3f2e11f commit f8149de
4 files changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
242 | 245 | | |
243 | 246 | | |
244 | 247 | | |
| |||
0 commit comments