Skip to content

Commit 7c18c1a

Browse files
committed
removed setup-script job
Signed-off-by: danish9039 <[email protected]>
1 parent 7fd5068 commit 7c18c1a

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

.github/workflows/ci-lint-test.yml

-9
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,7 @@ permissions:
1717
contents: read
1818

1919
jobs:
20-
setup-scripts:
21-
runs-on: ubuntu-latest
22-
steps:
23-
- uses: actions/checkout@v3
24-
- name: Setup lint scripts
25-
run: make setup-scripts
26-
27-
2820
lint:
29-
needs: setup-scripts
3021
runs-on: ubuntu-latest
3122
steps:
3223
- uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7

Makefile

+8-8
Original file line numberDiff line numberDiff line change
@@ -194,14 +194,6 @@ define proto_compile
194194

195195
endef
196196

197-
.PHONY: setup-scripts
198-
setup-scripts:
199-
rm -rf .scripts/lint
200-
mkdir -p .scripts/lint
201-
curl -o .scripts/lint/updateLicense.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/updateLicense.py
202-
curl -o .scripts/lint/import-order-cleanup.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/import-order-cleanup.py
203-
chmod +x .scripts/lint/*.py
204-
205197
.PHONY: lint
206198
lint: lint-imports lint-nocommit lint-license lint-go
207199

@@ -212,7 +204,12 @@ lint-go: $(LINT)
212204
.PHONY: lint-license
213205
lint-license:
214206
@echo Verifying that all files have license headers
207+
@mkdir -p .scripts/lint
208+
@curl -s -o .scripts/lint/updateLicense.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/updateLicense.py
209+
@chmod +x .scripts/lint/updateLicense.py
215210
@./.scripts/lint/updateLicense.py $(ALL_SRC) $(SCRIPTS_SRC) > $(FMT_LOG)
211+
@[ -s "$(FMT_LOG)" ] || echo "✅ All files have license headers"
212+
216213

217214
.PHONY: lint-nocommit
218215
lint-nocommit:
@@ -224,6 +221,9 @@ lint-nocommit:
224221
.PHONY: lint-imports
225222
lint-imports:
226223
@echo Verifying that all files have correctly ordered imports
224+
@mkdir -p .scripts/lint
225+
@curl -s -o .scripts/lint/import-order-cleanup.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/import-order-cleanup.py
226+
@chmod +x .scripts/lint/import-order-cleanup.py
227227
@./.scripts/lint/import-order-cleanup.py -o stdout -t $(ALL_SRC) > $(IMPORT_LOG)
228228
@[ ! -s "$(IMPORT_LOG)" ] || (echo "Import ordering failures, run 'make fmt'" | cat - $(IMPORT_LOG) && false)
229229
@[ -s "$(IMPORT_LOG)" ] || echo "✅ All files have correctly ordered imports"

0 commit comments

Comments
 (0)