Skip to content

Commit d1d9a21

Browse files
authored
Extract url for scripts into variable (#141)
## Which problem is this PR solving? - part of jaegertracing/jaeger#6570 ## Description of the changes - extracted` https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts` into a variable `$(SCRIPTS_URL)` #121 (comment) ## How was this change tested? - ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: danish9039 <[email protected]>
1 parent 86b800d commit d1d9a21

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Makefile

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Copyright (c) 2023 The Jaeger Authors.
22
# SPDX-License-Identifier: Apache-2.0
3+
SCRIPTS_URL = https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts
34

45
JAEGER_IMPORT_PATH = github.com/jaegertracing/jaeger-idl
56

@@ -228,9 +229,9 @@ lint-imports: setup-lint-scripts
228229
.PHONY: setup-lint-scripts
229230
setup-lint-scripts:
230231
@mkdir -p .scripts/lint
231-
@curl -s -o .scripts/lint/import-order-cleanup.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/import-order-cleanup.py
232+
@curl -s -o .scripts/lint/import-order-cleanup.py $(SCRIPTS_URL)/lint/import-order-cleanup.py
232233
@chmod +x .scripts/lint/import-order-cleanup.py
233-
@curl -s -o .scripts/lint/updateLicense.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/updateLicense.py
234+
@curl -s -o .scripts/lint/updateLicense.py $(SCRIPTS_URL)/lint/updateLicense.py
234235
@chmod +x .scripts/lint/updateLicense.py
235236

236237
.PHONY: fmt

0 commit comments

Comments
 (0)