From d1d9a218f6b27d37cdf3ebd02b767e82cffaea3e Mon Sep 17 00:00:00 2001 From: hippie-danish <133037056+danish9039@users.noreply.github.com> Date: Fri, 31 Jan 2025 22:41:32 +0530 Subject: [PATCH] Extract url for scripts into variable (#141) ## Which problem is this PR solving? - part of https://github.com/jaegertracing/jaeger/issues/6570 ## Description of the changes - extracted` https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts` into a variable `$(SCRIPTS_URL)` https://github.com/jaegertracing/jaeger-idl/pull/121#discussion_r1937504454 ## How was this change tested? - ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: danish9039 --- Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 5190480..e42d1b0 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,6 @@ # Copyright (c) 2023 The Jaeger Authors. # SPDX-License-Identifier: Apache-2.0 +SCRIPTS_URL = https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts JAEGER_IMPORT_PATH = github.com/jaegertracing/jaeger-idl @@ -228,9 +229,9 @@ lint-imports: setup-lint-scripts .PHONY: setup-lint-scripts setup-lint-scripts: @mkdir -p .scripts/lint - @curl -s -o .scripts/lint/import-order-cleanup.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/import-order-cleanup.py + @curl -s -o .scripts/lint/import-order-cleanup.py $(SCRIPTS_URL)/lint/import-order-cleanup.py @chmod +x .scripts/lint/import-order-cleanup.py - @curl -s -o .scripts/lint/updateLicense.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/updateLicense.py + @curl -s -o .scripts/lint/updateLicense.py $(SCRIPTS_URL)/lint/updateLicense.py @chmod +x .scripts/lint/updateLicense.py .PHONY: fmt