fix(workers-tagged-logger): fix multi-arg message stringification and colo tag nesting

stringifyMessages() was called without spreading the msgs array, causing
multi-argument log calls to produce a JSON-stringified array instead of
space-separated individually-stringified messages.

getCfFromRequest() returns a CfProps object but the result was set via
shorthand { colo } creating a nested { colo: { colo: 'DFW' } } object
instead of the intended { colo: 'DFW' }.

Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>

Author: jahands

npm-pkgs/workers-tagged-logger/src/hono.spec.ts

@@ -54,6 +54,32 @@ describe('useWorkersLogger()', () => {
 		`)
 	})
 
+	it('sets colo tag as a flat string from request cf properties', async () => {
+		const h = setupTest()
+		const app = new Hono<App>()
+			.use(async (c, next) => {
+				c.env = { ENVIRONMENT: 'production' }
+				await next()
+			})
+			.use(useWorkersLogger('worker-a'))
+			.get(async (c) => {
+				h.log.info('hi')
+				return c.text('hello')
+			})
+
+		const req = new Request('https://example.com')
+		Object.defineProperty(req, 'cf', { value: { colo: 'DFW' }, writable: false })
+
+		const res = await app.fetch(req)
+		expect(await res.text()).toBe('hello')
+		expect(res.status).toBe(200)
+
+		const tags = h.oneLog().tags
+		expect(tags).toBeDefined()
+		expect(tags!.colo).toBe('DFW')
+		expect(tags!.environment).toBe('production')
+	})
+
 	it('does not add environment when not present in bindings', async () => {
 		const h = setupTest()
 		const app = new Hono<App>().use(useWorkersLogger('worker-a')).get(async (c) => {

npm-pkgs/workers-tagged-logger/src/hono.ts

@@ -34,9 +34,9 @@ export function useWorkersLogger<T extends LogTags>(
 				}
 			}
 
-			const colo = getCfFromRequest(c.req.raw)
-			if (colo !== null) {
-				log.setTags({ colo })
+			const cfProps = getCfFromRequest(c.req.raw)
+			if (cfProps !== null) {
+				log.setTags({ colo: cfProps.colo })
 			}
 
 			if (tags !== undefined) {

npm-pkgs/workers-tagged-logger/src/logger.ts

@@ -322,7 +322,7 @@ export class WorkersLogger<T extends LogTags> implements LogLevelFns {
 			} else if (msgs.length === 1) {
 				message = stringifyMessage(msgs[0])
 			} else {
-				message = stringifyMessages(msgs)
+				message = stringifyMessages(...msgs)
 			}
 		}
 

npm-pkgs/workers-tagged-logger/src/test/logger/logger.spec.ts

@@ -136,11 +136,11 @@ describe('WorkersLogger', () => {
 		test('multiple values are logged to the same log', async () => {
 			const h = setupTest()
 			await withLogTags({ source: 'worker-a' }, async () => {
-				h.log.info('hello', 123, new Error('boom!'), { banda: 'rocks' }, ['a', 'b'], {
+				h.log.info('hello', 123, 'error occurred', { banda: 'rocks' }, ['a', 'b'], {
 					foo: { bar: { baz: 'abc' } },
 				})
 				expect(h.oneLog().message).toMatchInlineSnapshot(
-					`"["hello",123,{},{"banda":"rocks"},["a","b"],{"foo":{"bar":{"baz":"abc"}}}]"`
+					`"hello 123 error occurred {"banda":"rocks"} ["a","b"] {"foo":{"bar":{"baz":"abc"}}}"`
 				)
 			})
 		})