chore: aligned review retry terminology

Author: jahilldev

api/src/orchestrator/orchestrator.service.spec.ts

@@ -133,7 +133,7 @@ function setup(overrides: { job?: Record<string, unknown> } = {}) {
     persist: resolved(undefined),
     threshold: 85,
     maxPasses: 5,
-    maxParseRetries: 2,
+    maxRetries: 2,
   };
 
   const verify = {

api/src/orchestrator/orchestrator.service.ts

@@ -1569,12 +1569,12 @@ export class OrchestratorService {
     // After MAX_REVIEW_RETRIES in a row the model is unlikely to self-correct, so fall through
     // to the draft-PR path rather than burning the entire pass budget on malformed output.
     const unparseablePasses = priorUnparseable + (parsed === null ? 1 : 0);
-    const maxParseRetries = this.review.maxParseRetries;
+    const maxRetries = this.review.maxRetries;
 
     // Only revise when the review produced parseable, actionable issues.
     // If the output couldn't be parsed, retry the review so the agent gets another
     // chance to emit valid JSON — but cap consecutive unparseable retries.
-    if (pass < maxPasses && (parsed !== null || unparseablePasses < maxParseRetries)) {
+    if (pass < maxPasses && (parsed !== null || unparseablePasses < maxRetries)) {
       if (parsed !== null) {
         await this.jobs.transition(jobId, 'REVISING', {
           reason: `addressing review pass ${pass}`,
@@ -1589,7 +1589,7 @@ export class OrchestratorService {
     }
 
     const reason =
-      unparseablePasses >= maxParseRetries
+      unparseablePasses >= maxRetries
         ? `Self-review produced unparseable output ${unparseablePasses} times in a row. Opening a draft PR for human review.`
         : `Self-review didn't reach the confidence threshold after ${pass} passes (best ${result.confidence}/100). Opening a draft PR for human review.`;
 

api/src/review/review.service.ts

@@ -56,7 +56,7 @@ export class ReviewService {
   }
 
   /** Max consecutive unparseable review passes tolerated before bailing to a draft PR. */
-  get maxParseRetries(): number {
+  get maxRetries(): number {
     return this.config.get('MAX_REVIEW_RETRIES');
   }