#whatwouldshellcheckdo

Author: jakejarvis

entrypoint.sh

@@ -1,4 +1,4 @@
-#!/bin/sh -l
+#!/bin/sh
 
 set -e
 
@@ -19,30 +19,30 @@ fi
 
 # If URL array is passed, only purge those. Otherwise, purge everything.
 if [ -n "$PURGE_URLS" ]; then
-  DATA_ARG='{"files":'"${PURGE_URLS}"'}'
+  set -- --data '{"files":'"${PURGE_URLS}"'}'
 else
-  DATA_ARG='{"purge_everything":true}'
+  set -- --data '{"purge_everything":true}'
 fi
 
 # Call the API and store the response for later.
 HTTP_RESPONSE=$(curl -sS -X POST "https://api.cloudflare.com/client/v4/zones/${CLOUDFLARE_ZONE}/purge_cache" \
-         -H "X-Auth-Email: ${CLOUDFLARE_EMAIL}" \
-         -H "X-Auth-Key: ${CLOUDFLARE_KEY}" \
-         -H "Content-Type: application/json" \
-         --data ${DATA_ARG} \
-         --write-out "HTTP_STATUS:%{http_code}")
+                     -H "X-Auth-Email: ${CLOUDFLARE_EMAIL}" \
+                     -H "X-Auth-Key: ${CLOUDFLARE_KEY}" \
+                     -H "Content-Type: application/json" \
+                     -w "HTTP_STATUS:%{http_code}" \
+                     "$@")
 
 # Store result and HTTP status code separately to appropriately throw CI errors.
 # https://gist.github.com/maxcnunes/9f77afdc32df354883df
-HTTP_BODY=$(echo $HTTP_RESPONSE | sed -E 's/HTTP_STATUS\:[0-9]{3}$//')
-HTTP_STATUS=$(echo $HTTP_RESPONSE | tr -d '\n' | sed -E 's/.*HTTP_STATUS:([0-9]{3})$/\1/')
+HTTP_BODY=$(echo "${HTTP_RESPONSE}" | sed -E 's/HTTP_STATUS\:[0-9]{3}$//')
+HTTP_STATUS=$(echo "${HTTP_RESPONSE}" | tr -d '\n' | sed -E 's/.*HTTP_STATUS:([0-9]{3})$/\1/')
 
 # Fail pipeline and print errors if API doesn't return an OK status.
-if [ $HTTP_STATUS -eq "200" ]; then
+if [ "${HTTP_STATUS}" -eq "200" ]; then
   echo "Successfully purged!"
   exit 0
 else
-  echo "Purge failed. API response was:"
-  echo $HTTP_BODY
+  echo "Purge failed. API response was: "
+  echo "${HTTP_BODY}"
   exit 1
 fi