Commit 7f83f81
committed
Address PR lchrusciel#209 review comments: improve diff output formatting
- Remove redundant matcher error message from assertResponseContent
The detailed "Value X does not match pattern Y" message was duplicating
information already visible in the contextual diff
- Move expected file path to end of diff output in absolute format
The file path now appears at the bottom as "Expected file: /absolute/path"
making it easier to reference after reviewing the diff
- Update all tests to reflect the new file path format
Note: Pattern matcher normalization (avoiding display of passing pattern
matches in diff) remains a complex issue requiring deeper refactoring of
how expected responses are compared with actual responses.
https://claude.ai/code/session_014m1n4X3T8cCXz2HguPjWFH1 parent 680b12d commit 7f83f81
5 files changed
Lines changed: 10 additions & 13 deletions
File tree
- src
- Renderer
- test/src/Tests
- Controller
- Renderer
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | | - | |
| 195 | + | |
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | 52 | | |
59 | 53 | | |
60 | 54 | | |
| |||
100 | 94 | | |
101 | 95 | | |
102 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
171 | | - | |
| 171 | + | |
172 | 172 | | |
173 | | - | |
174 | 173 | | |
175 | 174 | | |
176 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
| 105 | + | |
106 | 106 | | |
107 | | - | |
108 | 107 | | |
109 | 108 | | |
110 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | | - | |
| 73 | + | |
75 | 74 | | |
76 | 75 | | |
77 | 76 | | |
| |||
0 commit comments