Skip to content

actionHookDelayAction, retries with multiple actions. #1155

Open
jambonz/jambonz-fern-config
#44
@sammachin

Description

@sammachin

Currently the retries property of the actionHookDelayAction is applied to each verb in the actions array, so if you have a sat then a play in your actions but retries set to 1 it will only invoke the say.

So if you have 2 verbs [say, play] and want them both to be run twice [say, play, say, play] you would need to set retries to 4.

This is due to this line

which increments the retryCount on each verb not on the run of the array.

We could fix this by multiplying retries by the length of the actions array at

this.retries = opts.retries || 0;

this.retries = (opts.retries || 1) * opts.actions.length

However this would be a breaking change to the current experience and anyone that has multiple actions in their array but expects each one to only play once would see them looping.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions