remove send_options_bots array (#129)

fixes ticket #1983

Co-authored-by: rhonda hollis <rhonda@jambonz.org>

Author: rhondahollis

lib/sip-trunk-options-ping.js

@@ -2,7 +2,6 @@ const { addSipGatewayToBlacklist, removeSipGatewayFromBlacklist, isSipGatewayBla
 const {OPTIONS_RESPONSE_REMOVE} = require('./config');
 
 const send_options_gateways = [];
-const send_options_bots = [];
 
 class OptionsBot {
   constructor(logger, gateway) {
@@ -93,6 +92,7 @@ class OptionsBot {
 }
 
 module.exports = async(logger, srf) => {
+
   const updateSipGatewayOptsBot = async(logger, srf) => {
     try {
 
@@ -105,10 +105,9 @@ module.exports = async(logger, srf) => {
         send_options_gateways.push(...gws);
         for (const g of send_options_gateways) {
           const optsBot = new OptionsBot(logger, g);
-          send_options_bots.push(optsBot);
           optsBot.options(srf);
         }
-        logger.debug(`updateSipGatewayOptsBot: we have started ${send_options_bots.length} optionsBots`);
+        logger.debug(`updateSipGatewayOptsBot: we have started ${send_options_gateways.length} optionsBots`);
       }
     } catch (err) {
       logger.error({ err }, 'updateSipGatewayOptsBot Error');

test/regbot-tests.js

@@ -72,7 +72,6 @@ test('trunk register tests', (t) => {
     })
     .then(() => {
       const obj = srf.locals.regbotStatus();
-      //console.log({obj}, 'regbot status after adding new gateway');
       return t.ok(obj.total === 2 && obj.registered === 1, 'successfully added gateway that tests failure result');
     })
     .then(() => {