wip

Author: xquanluu

app.js

@@ -260,7 +260,7 @@ srf.register(require('./lib/register')({logger}));
 srf.options(require('./lib/options')({srf, logger}));
 
 // Start CLI runtime config server with access to srf.locals
-require('./lib/cli/runtime-config').initialize(srf.locals);
+require('./lib/cli/runtime-config').initialize(srf.locals, logger);
 
 setInterval(async() => {
   const count = await srf.locals.registrar.getCountOfUsers();

lib/cli/runtime-config.js

@@ -1,9 +1,9 @@
 const net = require('net');
-const logger = require('pino')({ level: process.env.JAMBONES_LOGLEVEL || 'info' });
 
 const config = new Map();
 const queue = [];
 let processing = false;
+let logger;
 
 async function runOperation(operation) {
   return new Promise((resolve, reject) => {
@@ -31,10 +31,15 @@ async function processQueue() {
 }
 
 class RuntimeConfig {
-  constructor(srfLocals = null) {
+  constructor(srfLocals = null, appLogger = null) {
     this.server = null;
     this.socketPath = process.env.SBC_SOCKET_PATH || '/tmp/sbc-sip-sidecar.sock';
     this.srfLocals = srfLocals;
+    if (appLogger) {
+      logger = appLogger;
+    } else if (!logger) {
+      throw new Error('Logger is required for RuntimeConfig');
+    }
     this.startServer();
   }
 
@@ -387,32 +392,36 @@ class RuntimeConfig {
 
 let runtimeConfig = null;
 
-function createInstance(srfLocals = null) {
-  const instance = new RuntimeConfig(srfLocals);
+function createInstance(srfLocals = null, appLogger = null) {
+  const instance = new RuntimeConfig(srfLocals, appLogger);
   process.on('SIGINT', () => instance.shutdown());
   process.on('SIGTERM', () => instance.shutdown());
   return instance;
 }
 
-function initializeRuntimeConfig(srfLocals) {
+function initialize(srfLocals, appLogger) {
+  if (!appLogger) {
+    throw new Error('Logger is required for RuntimeConfig initialization');
+  }
   if (!runtimeConfig) {
-    runtimeConfig = createInstance(srfLocals);
+    runtimeConfig = createInstance(srfLocals, appLogger);
   } else {
-    // Update existing instance with srfLocals
+    // Update existing instance with srfLocals and logger
     runtimeConfig.srfLocals = srfLocals;
+    logger = appLogger;
   }
 
   return runtimeConfig;
 }
 
 function getInstance() {
   if (!runtimeConfig) {
-    runtimeConfig = createInstance();
+    throw new Error('RuntimeConfig not initialized. Call initialize() first with logger.');
   }
   return runtimeConfig;
 }
 
 module.exports = {
-  initialize: initializeRuntimeConfig,
+  initialize,
   getInstance
 };