fix compiled-objects-have-debug-symbols on macOS (#205)

Author: jameslamb

bin/run-smoke-tests.sh

@@ -77,7 +77,7 @@ pydistcheck ./smoke-tests/*
 # other complex projects that do custom packaging stuff
 get-files apache-airflow
 pydistcheck \
-    --ignore 'mixed-file-extensions' \
+    --ignore 'mixed-file-extensions,unexpected-files' \
     ./smoke-tests/*
 
 get-files astropy

src/pydistcheck/config.py

@@ -4,6 +4,7 @@
   * validating configuration values
   * updating configuuration from files
 """
+
 import os
 from dataclasses import dataclass
 from typing import Any, Dict

src/pydistcheck/shared_lib_utils.py

@@ -65,8 +65,8 @@ def _get_symbols(cmd_args: List[str], lib_file: str) -> str:
 
 def _nm_reports_debug_symbols(tool_name: str, lib_file: str) -> Tuple[bool, str]:
     exported_symbols = _get_symbols(cmd_args=[tool_name], lib_file=lib_file)
-    all_symbols = _get_symbols(cmd_args=[tool_name, "--debug-syms"], lib_file=lib_file)
-    return exported_symbols != all_symbols, f"{tool_name} --debug-syms"
+    all_symbols = _get_symbols(cmd_args=[tool_name, "-a"], lib_file=lib_file)
+    return exported_symbols != all_symbols, f"{tool_name} -a"
 
 
 def _archive_member_has_debug_symbols(archive_file: str, file_info: _FileInfo) -> Tuple[bool, str]:

tests/test_cli.py

@@ -557,7 +557,7 @@ def test_debug_symbols_check_works(distro_file):
     assert result.exit_code == 1, result.output
     if "macosx" in distro_file:
         if platform.startswith("cygwin") or platform.startswith("win"):
-            debug_cmd = r"'llvm\-nm \-\-debug\-syms \"lib/lib_baseballmetrics\.dylib\"'\."
+            debug_cmd = r"'llvm\-nm \-a \"lib/lib_baseballmetrics\.dylib\"'\."
         else:
             # dsymutil works on both macOS and Linux
             debug_cmd = r"'dsymutil \-s \"lib/lib_baseballmetrics\.dylib\"'\."