Skip to content

Commit c411bc2

Browse files
jamestjspclaude
andcommitted
fix: revert over-aggressive slicot→ctrlsys renames in tests
- eig_slicot/eigs_slicot are variable names, not module refs - _slicot is the C extension module name (unchanged) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 35491e2 commit c411bc2

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

tests/python/test_mb03bd.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,9 +369,9 @@ def test_mb03bd_negative_signature():
369369
eig_slicot = []
370370
for i in range(n):
371371
if beta[i] != 0:
372-
eig_ctrlsys.append((alphar[i] + 1j * alphai[i]) / beta[i] * (base ** scal[i]))
372+
eig_slicot.append((alphar[i] + 1j * alphai[i]) / beta[i] * (base ** scal[i]))
373373
else:
374-
eig_ctrlsys.append(np.inf)
374+
eig_slicot.append(np.inf)
375375
eig_slicot = np.array(eig_slicot)
376376

377377
# Sort and compare

tests/python/test_mb04nd.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def test_mb04nd_basic_full():
7878

7979
from ctrlsys import _slicot
8080

81-
tau = _ctrlsys.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
81+
tau = _slicot.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
8282

8383
assert len(tau) == n
8484
assert np.all(np.isfinite(r_work))
@@ -115,7 +115,7 @@ def test_mb04nd_upper_triangular():
115115

116116
from ctrlsys import _slicot
117117

118-
tau = _ctrlsys.mb04nd('U', n, m, p, r_work, a_work, b_work, c_work)
118+
tau = _slicot.mb04nd('U', n, m, p, r_work, a_work, b_work, c_work)
119119

120120
assert len(tau) == n
121121
for i in range(n):
@@ -146,7 +146,7 @@ def test_mb04nd_orthogonality():
146146

147147
from ctrlsys import _slicot
148148

149-
tau = _ctrlsys.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
149+
tau = _slicot.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
150150

151151
q = np.eye(n + p, dtype=float)
152152
for i in range(n - 1, -1, -1):
@@ -189,7 +189,7 @@ def test_mb04nd_n_zero():
189189

190190
from ctrlsys import _slicot
191191

192-
tau = _ctrlsys.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
192+
tau = _slicot.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
193193

194194
assert len(tau) == 0
195195
np.testing.assert_array_equal(c_work, c_orig)
@@ -218,7 +218,7 @@ def test_mb04nd_p_zero():
218218

219219
from ctrlsys import _slicot
220220

221-
tau = _ctrlsys.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
221+
tau = _slicot.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
222222

223223
assert len(tau) == n
224224
np.testing.assert_array_equal(r_work, r_orig)
@@ -248,7 +248,7 @@ def test_mb04nd_m_zero():
248248

249249
from ctrlsys import _slicot
250250

251-
tau = _ctrlsys.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
251+
tau = _slicot.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
252252

253253
assert len(tau) == n
254254
for i in range(n):
@@ -278,7 +278,7 @@ def test_mb04nd_large_matrix():
278278

279279
from ctrlsys import _slicot
280280

281-
tau = _ctrlsys.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
281+
tau = _slicot.mb04nd('F', n, m, p, r_work, a_work, b_work, c_work)
282282

283283
assert len(tau) == n
284284
for i in range(n):
@@ -313,7 +313,7 @@ def test_mb04nd_n_greater_p():
313313

314314
from ctrlsys import _slicot
315315

316-
tau = _ctrlsys.mb04nd('U', n, m, p, r_work, a_work, b_work, c_work)
316+
tau = _slicot.mb04nd('U', n, m, p, r_work, a_work, b_work, c_work)
317317

318318
assert len(tau) == n
319319
for i in range(n):

tests/python/test_mb04ny.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def test_mb04ny_basic_2x2():
7878

7979
a_out = a.copy(order='F')
8080
b_out = b.copy(order='F')
81-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
81+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
8282

8383
np.testing.assert_allclose(a_out, a_expected, rtol=1e-14)
8484
np.testing.assert_allclose(b_out, b_expected, rtol=1e-14)
@@ -106,7 +106,7 @@ def test_mb04ny_3x3():
106106

107107
a_out = a.copy(order='F')
108108
b_out = b.copy(order='F')
109-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
109+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
110110

111111
np.testing.assert_allclose(a_out, a_expected, rtol=1e-14)
112112
np.testing.assert_allclose(b_out, b_expected, rtol=1e-14)
@@ -134,7 +134,7 @@ def test_mb04ny_5x5():
134134

135135
a_out = a.copy(order='F')
136136
b_out = b.copy(order='F')
137-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
137+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
138138

139139
np.testing.assert_allclose(a_out, a_expected, rtol=1e-13)
140140
np.testing.assert_allclose(b_out, b_expected, rtol=1e-13)
@@ -162,7 +162,7 @@ def test_mb04ny_10x10():
162162

163163
a_out = a.copy(order='F')
164164
b_out = b.copy(order='F')
165-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
165+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
166166

167167
np.testing.assert_allclose(a_out, a_expected, rtol=1e-12)
168168
np.testing.assert_allclose(b_out, b_expected, rtol=1e-12)
@@ -190,7 +190,7 @@ def test_mb04ny_large_general():
190190

191191
a_out = a.copy(order='F')
192192
b_out = b.copy(order='F')
193-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
193+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
194194

195195
np.testing.assert_allclose(a_out, a_expected, rtol=1e-13)
196196
np.testing.assert_allclose(b_out, b_expected, rtol=1e-13)
@@ -219,7 +219,7 @@ def test_mb04ny_tau_zero():
219219

220220
a_out = a.copy(order='F')
221221
b_out = b.copy(order='F')
222-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
222+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
223223

224224
np.testing.assert_allclose(a_out, a_expected, rtol=1e-14)
225225
np.testing.assert_allclose(b_out, b_expected, rtol=1e-14)
@@ -262,7 +262,7 @@ def test_mb04ny_m_zero():
262262

263263
a_out = a.copy(order='F')
264264
b_out = b.copy(order='F')
265-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
265+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
266266

267267
assert a_out.shape == (0, 1)
268268
assert b_out.shape == (0, n)
@@ -290,7 +290,7 @@ def test_mb04ny_n_zero():
290290

291291
a_out = a.copy(order='F')
292292
b_out = b.copy(order='F')
293-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
293+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
294294

295295
np.testing.assert_allclose(a_out, a_expected, rtol=1e-14)
296296
assert b_out.shape == (m, 0)
@@ -319,7 +319,7 @@ def test_mb04ny_incv_positive():
319319

320320
a_out = a.copy(order='F')
321321
b_out = b.copy(order='F')
322-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
322+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
323323

324324
np.testing.assert_allclose(a_out, a_expected, rtol=1e-14)
325325
np.testing.assert_allclose(b_out, b_expected, rtol=1e-14)
@@ -346,7 +346,7 @@ def test_mb04ny_incv_negative():
346346

347347
a_out = a.copy(order='F')
348348
b_out = b.copy(order='F')
349-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
349+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
350350

351351
np.testing.assert_allclose(a_out, a_expected, rtol=1e-14)
352352
np.testing.assert_allclose(b_out, b_expected, rtol=1e-14)
@@ -373,7 +373,7 @@ def test_mb04ny_single_row():
373373

374374
a_out = a.copy(order='F')
375375
b_out = b.copy(order='F')
376-
_ctrlsys.mb04ny(m, n, v, incv, tau, a_out, b_out)
376+
_slicot.mb04ny(m, n, v, incv, tau, a_out, b_out)
377377

378378
np.testing.assert_allclose(a_out, a_expected, rtol=1e-14)
379379
np.testing.assert_allclose(b_out, b_expected, rtol=1e-14)

tests/python/test_sg03ad.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ def test_eigenvalue_computation():
384384
for i in range(n):
385385
if abs(beta[i]) > 1e-14:
386386
eig = (alphar[i] + 1j * alphai[i]) / beta[i]
387-
eigs_ctrlsys.append(eig)
387+
eigs_slicot.append(eig)
388388

389389
eigs_slicot_remaining = list(eigs_slicot)
390390
for e1 in eigs_numpy:

0 commit comments

Comments
 (0)