Skip to content

Commit 7bc6d7c

Browse files
authored
Merge pull request #37 from jamiefdhurst/fix-sorting-for-folders
fix: folder sorting includes sub-folder names correctly
2 parents f583ea9 + e960f08 commit 7bc6d7c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/__tests__/modal/folder-suggest.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ describe('FolderSuggest', () => {
4040
expect(elDispatch).toHaveBeenCalled();
4141
});
4242

43-
it('gets suggestions', () => {
43+
it('gets suggestions in the correct order', () => {
4444
const suggestions = sut.exposeGetSuggestions('BA');
4545

46-
expect(suggestions).toEqual(['foo/Bar', 'baz']);
46+
expect(suggestions).toEqual(['baz', 'foo/Bar']);
4747
});
4848
});

src/modal/folder-suggest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export class FolderSuggest extends AbstractInputSuggest<string> {
1616
protected getSuggestions(query: string): string[] {
1717
query = query.toLocaleLowerCase();
1818

19-
return [...this.folders].filter((path) => path.toLocaleLowerCase().contains(query));
19+
return [...this.folders].filter((path) => path.toLocaleLowerCase().contains(query)).sort();
2020
}
2121

2222
renderSuggestion(value: string, el: HTMLElement): void {

0 commit comments

Comments
 (0)