Acts - stopped working with invisible units

[EKhots]

For some reason it stopped working with enemy's invisible units. They just don't get selected. I'm use: tfow, acts.

They are generated, but simply remain invisible - they cannot be selected. Apparently this is due to an update related to the survey or so.

HeroesOfTheStorm_TryMode2.0/(10)trymemode.stormmap/base.stormdata/Modules/LibUtilities.galaxy

Lines 216 to 241 in c9b0089

	bool libUTIL_gt_ToggleFOW_Func (bool testConds, bool runActions) {
	// Automatic Variable Declarations
	// Actions
	if (!runActions) {
	return true;
	}
	libUTIL_gv_isFOWEnabled = !(libUTIL_gv_isFOWEnabled);
	if ((libUTIL_gv_isFOWEnabled == true)) {
	VisRevealerDestroy(libUTIL_gv_revealer);
	UIDisplayMessage(PlayerGroupAll(), c_messageAreaDebug, StringToText("Enabled Fog Of War"));
	}
	else {
	VisRevealerCreate(EventPlayer(), RegionEntireMap());
	libUTIL_gv_revealer = VisRevealerLastCreated();
	UIDisplayMessage(PlayerGroupAll(), c_messageAreaDebug, StringToText("Disabled Fog Of War"));
	}
	return true;
	}
	//--------------------------------------------------------------------------------------------------
	void libUTIL_gt_ToggleFOW_Init () {
	libUTIL_gt_ToggleFOW = TriggerCreate("libUTIL_gt_ToggleFOW_Func");
	TriggerAddEventChatMessage(libUTIL_gt_ToggleFOW, c_playerAny, "tfow", true);
	TriggerAddEventChatMessage(libUTIL_gt_ToggleFOW, c_playerAny, "togglefogofwar", true);
	}

HeroesOfTheStorm_TryMode2.0/(10)trymemode.stormmap/base.stormdata/Modules/LibUtilities.galaxy

Lines 676 to 719 in c9b0089

	bool libUTIL_gt_ToggleACTS_Func (bool testConds, bool runActions) {
	// Variable Declarations
	bool lv_isTSEnabled;
	int lv_i;
	// Automatic Variable Declarations
	const int auto742BDE96_ae = 15;
	const int auto742BDE96_ai = 1;
	const int autoDCF572B4_ae = 15;
	const int autoDCF572B4_ai = 1;
	// Variable Initialization
	// Actions
	if (!runActions) {
	return true;
	}
	libUTIL_gv_isACTSEnabled = !(libUTIL_gv_isACTSEnabled);
	lv_isTSEnabled = libSprt_gv_dEBUGSelectionEnabled;
	if ((libUTIL_gv_isACTSEnabled == true)) {
	UIDisplayMessage(PlayerGroupAll(), c_messageAreaDebug, StringToText("Turned ON Alliance Control and Team Selection (/ac, ts)"));
	lv_i = 1;
	for ( ; ( (autoDCF572B4_ai >= 0 && lv_i <= autoDCF572B4_ae) || (autoDCF572B4_ai < 0 && lv_i >= autoDCF572B4_ae) ) ; lv_i += autoDCF572B4_ai ) {
	PlayerSetAlliance(lv_i, c_allianceIdControl, EventPlayer(), true);
	}
	if ((lv_isTSEnabled != true)) {
	libSprt_gf_DEBUGToggleSelection();
	}
	}
	else {
	UIDisplayMessage(PlayerGroupAll(), c_messageAreaDebug, StringToText("Turned OFF Alliance Control and Team Selection (/ac, ts)"));
	lv_i = 1;
	for ( ; ( (auto742BDE96_ai >= 0 && lv_i <= auto742BDE96_ae) || (auto742BDE96_ai < 0 && lv_i >= auto742BDE96_ae) ) ; lv_i += auto742BDE96_ai ) {
	PlayerSetAlliance(lv_i, c_allianceIdControl, EventPlayer(), true);
	}
	if ((lv_isTSEnabled != false)) {
	libSprt_gf_DEBUGToggleSelection();
	}
	}
	return true;
	}

[EKhots]

I see that changes are being made to Try Mode. I will describe the situation in more detail. You can't test this in (10)trymemode.stormmap, since you can't play as an enemy hero there.

1. I install the map from: https://github.com/jamiephan/HeroesOfTheStorm_TryMode2.0Installer/releases/tag/v1.4.0 - for example, Alterac.
2. I turn off the fog of war (tfow).
3. I launch and summon an enemy hero (any invisible one, like Zeratul, Nova, etc.).
4. These heroes cannot be clicked and controlled. In some patch for 2024, they made changes to unit overviews, and here's the problem.

Now I solved this issue for Nova in the following way:

For CEffectSet id="NovaPermanentCloakInitialSet" I moved everything from:

<CEffectSet id="NovaPermanentCloakExpireSet"> 
<EffectArray value="ApplyGenericDecloakCaster" /> 
<EffectArray value="NovaPermanentCloakRemoveMovespeedBehavior" /> 
<EffectArray value="NovaIonicForceFieldApplyArmorBehavior" /> 
</CEffectSet>

And it turned out:

<CEffectSet id="NovaPermanentCloakInitialSet"> 
<EffectArray value="ApplyGenericDecloakCaster" /> 
<EffectArray value="NovaPermanentCloakRemoveMovespeedBehavior" /> 
<EffectArray value="NovaIonicForceFieldApplyArmorBehavior" />
</CEffectSet>

Now she just doesn't go invisible, and you can control her that way. Surely there is a better way? Now there is a similar way for Zeratul. There is also Valeera... and Medivh, Brightwing can be sent into invisible, which causes loss of control.

[jamiephan]

Let me see what I can do.

My idea is a map size effect that uses some trait of "<CBehaviorBuff default="1" id="StormReveal">". Think of like a map size Tassadar Oracle reveal without the annoying "red eye reveal icon" on the top