Skip to content

Commit 9079790

Browse files
committed
Add strings to make Reminders and Calibration graph fully translated
1 parent e68816a commit 9079790

File tree

7 files changed

+30
-16
lines changed

7 files changed

+30
-16
lines changed

app/src/main/java/com/eveningoutpost/dexdrip/CalibrationGraph.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public void setupCharts() {
8888
DecimalFormat df = new DecimalFormat("#");
8989
df.setMaximumFractionDigits(2);
9090
df.setMinimumFractionDigits(2);
91-
String Header = "slope = " + df.format(calibration.slope) + " intercept = " + df.format(calibration.intercept);
91+
String Header = getString(R.string.calibration_slope_intercept, df.format(calibration.slope), df.format(calibration.intercept));
9292
GraphHeader.setText(Header);
9393

9494
//red line
@@ -133,8 +133,8 @@ public void setupCharts() {
133133
}
134134
Axis axisX = new Axis();
135135
Axis axisY = new Axis().setHasLines(true);
136-
axisX.setName("Raw Value");
137-
axisY.setName("Glucose " + (doMgdl ? "mg/dl" : "mmol/l"));
136+
axisX.setName(getString(R.string.axis_x_raw_value));
137+
axisY.setName(getString(R.string.axis_y_glucose_mgdl_mmol, (doMgdl ? "mg/dl" : "mmol/l")));
138138

139139

140140
data = new LineChartData(lines);

app/src/main/java/com/eveningoutpost/dexdrip/Reminders.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1022,7 +1022,7 @@ public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
10221022

10231023
dialogBuilder.setTitle(((reminder == null) ? xdrip.getAppContext().getString(R.string.title_add_reminder) : xdrip.getAppContext().getString(R.string.title_edit_reminder)));
10241024
//dialogBuilder.setMessage("Enter text below");
1025-
dialogBuilder.setPositiveButton("Done", new DialogInterface.OnClickListener() {
1025+
dialogBuilder.setPositiveButton(xdrip.getAppContext().getString(R.string.done), new DialogInterface.OnClickListener() {
10261026
public void onClick(DialogInterface dialog, int whichButton) {
10271027
String reminder_title = titleEditText.getText().toString().trim();
10281028
Log.d(TAG, "Got reminder title: " + reminder_title);

app/src/main/java/com/eveningoutpost/dexdrip/utils/HomeWifi.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ public static void ask(final Activity activity) {
3838
if (isConnectedToAnything()) {
3939
final String ssid = getSSID();
4040
final AlertDialog.Builder builder = new AlertDialog.Builder(activity);
41-
builder.setTitle("Set Home Network");
42-
builder.setMessage(String.format("My Home WiFi Network name is:\n\n%s", ssid));
41+
builder.setTitle(activity.getString(R.string.set_home_network));
42+
builder.setMessage(activity.getString(R.string.my_home_network_is, ssid));
4343

4444
builder.setPositiveButton(activity.getString(R.string.yes), new DialogInterface.OnClickListener() {
4545
@Override
4646
public void onClick(DialogInterface dialog, int which) {
4747
Pref.setString(PREF,ssid);
48-
JoH.static_toast_long(String.format("Set home network to: %s",ssid));
48+
JoH.static_toast_long(activity.getString(R.string.set_home_network_to, ssid));
4949
}
5050
});
5151
builder.setNegativeButton(activity.getString(R.string.cancel), new DialogInterface.OnClickListener() {
@@ -57,7 +57,7 @@ public void onClick(DialogInterface dialog, int which) {
5757

5858
builder.create().show();
5959
} else {
60-
JoH.static_toast_long("Not connected to Wifi");
60+
JoH.static_toast_long(activity.getString(R.string.not_connected_to_wifi));
6161
}
6262
}
6363

app/src/main/res/layout/reminder_new_dialog.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
android:id="@+id/reminder_edit_alt_title"
1717
android:layout_width="match_parent"
1818
android:layout_height="wrap_content"
19-
android:hint="Reminder alternate title"
19+
android:hint="@string/reminder_alternate_title"
2020
android:inputType="text|textCapWords"
2121
android:lines="4"
2222
android:linksClickable="false"
@@ -192,7 +192,7 @@
192192
android:layout_below="@+id/weekEndsCheckbox"
193193
android:layout_alignParentStart="true"
194194
android:checked="false"
195-
android:text="Graph Note"/>
195+
android:text="@string/graph_note"/>
196196

197197
<CheckBox
198198
android:id="@+id/speakCheckbox"
@@ -202,7 +202,7 @@
202202
android:layout_marginLeft="10dp"
203203
android:layout_toRightOf="@+id/GraphIconCheckbox"
204204
android:checked="false"
205-
android:text="Speak" />
205+
android:text="@string/speak" />
206206

207207
<CheckBox
208208
android:id="@+id/homeOnlyCheckbox"
@@ -212,7 +212,7 @@
212212
android:layout_marginLeft="10dp"
213213
android:layout_marginTop="3dp"
214214
android:checked="false"
215-
android:text="At Home Only" />
215+
android:text="@string/at_home_only" />
216216

217217
<CheckBox
218218
android:id="@+id/highPriorityCheckbox"

app/src/main/res/menu/menu_reminders.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848

4949
<item
5050
android:id="@+id/reminders_home_network"
51-
android:title="Set Home Network"
51+
android:title="@string/set_home_network"
5252
android:visible="true"
5353
android:onClick="onRemindersHomeNetworkClick"
5454
/>

app/src/main/res/values/arrays.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,9 @@
200200
</string-array>
201201

202202
<string-array name="reminderAlertType">
203-
<item>Android Ringtone/Alarm</item>
204-
<item>Custom Audio file</item>
205-
<item>Default xDrip+ reminder sound</item>
203+
<item>@string/android_ringtone_alarm</item>
204+
<item>@string/custom_audio_file</item>
205+
<item>@string/default_xdrip_reminder_sound</item>
206206
</string-array>
207207

208208
<!-- TODO abstract noise values to single source -->

app/src/main/res/values/strings.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1942,4 +1942,18 @@
19421942
<string name="bg_alert">BG %1$s ALERT: %2$s (@%3$s)</string>
19431943
<string name="show_graphical_trend_arrow">Show Graphical Trend Arrow</string>
19441944
<string name="no_alert_in_silent_mode">No Alert in Silent mode</string>
1945+
<string name="calibration_slope_intercept">slope = %1$s intercept = %2$s</string>
1946+
<string name="axis_x_raw_value">Raw Value</string>
1947+
<string name="axis_y_glucose_mgdl_mmol">Glucose + %s</string>
1948+
<string name="set_home_network">Set Home Network</string>
1949+
<string name="my_home_network_is">My Home WiFi Network name is:\n\n%s</string>
1950+
<string name="set_home_network_to">Set home network to: %s</string>
1951+
<string name="not_connected_to_wifi">Not connected to WiFi</string>
1952+
<string name="at_home_only">At Home Only</string>
1953+
<string name="speak">Speak</string>
1954+
<string name="graph_note">Graph Note</string>
1955+
<string name="reminder_alternate_title">Reminder alternate title</string>
1956+
<string name="default_xdrip_reminder_sound">Default xDrip+ reminder sound</string>
1957+
<string name="custom_audio_file">Custom Audio file</string>
1958+
<string name="android_ringtone_alarm">Android Ringtone/Alarm</string>
19451959
</resources>

0 commit comments

Comments
 (0)