Add interface tests and add initialize!

Author: janbruedigam

README.md

@@ -20,7 +20,7 @@ dimensions = [2; 3; 0; 1] # The dimension of row/column
 
 system = System{Float64}(graph_matrix, dimensions; symmetric=false) # The resulting linear system. Set symmetric=true for symmetric systems
 
-randomize!(system) # Randomize all system entries
+initialize!(system) # initialize! all system entries
 system.matrix_entries[1,2].value = rand(2,3) # Directly set the value of a matrix entry
 system.vector_entries[4].value = rand(1) # Directly set the value of a vector entry
 

benchmark/example_benchmark.jl

@@ -77,8 +77,8 @@ A[13,21] = A[21,13] = 1
 A[16,30] = A[30,16] = 1
 A[20,36] = A[36,20] = 1
 
-function randomize_posdef!(system)
-    randomize!(system,rand)
+function initialize!_posdef!(system)
+    initialize!(system,rand)
     for i=1:size(A)[1]
         system.matrix_entries[i,i].value += 1000*I 
     end
@@ -89,10 +89,10 @@ system = System{Float64}(A, ones(Int,size(A)[1])*3)
 systemldlt = System{Float64}(A, ones(Int,size(A)[1])*3, symmetric=true)
 systemllt = System{Float64}(A, ones(Int,size(A)[1])*3, symmetric=true)
 
-SUITE["ldu"] = @benchmarkable ldu_solve!($system) samples=2 setup=(randomize!($system))
-SUITE["lu"] = @benchmarkable lu_solve!($system) samples=2 setup=(randomize!($system))
-SUITE["ldlt"] = @benchmarkable ldlt_solve!($systemldlt) samples=2 setup=(randomize!($systemldlt))
-SUITE["llt"] = @benchmarkable llt_solve!($systemllt) samples=2 setup=(randomize_posdef!($systemllt))
+SUITE["ldu"] = @benchmarkable ldu_solve!($system) samples=2 setup=(initialize!($system))
+SUITE["lu"] = @benchmarkable lu_solve!($system) samples=2 setup=(initialize!($system))
+SUITE["ldlt"] = @benchmarkable ldlt_solve!($systemldlt) samples=2 setup=(initialize!($systemldlt))
+SUITE["llt"] = @benchmarkable llt_solve!($systemllt) samples=2 setup=(initialize!_posdef!($systemllt))
 
 # A = [
 #     0 1 1 1 1

src/GraphBasedSystems.jl

@@ -11,7 +11,7 @@ export System,
 
     full_matrix,
     full_vector,
-    randomize!,
+    initialize!,
     reset_inverse_diagonals!,
 
     children,

src/system/entry.jl

@@ -28,7 +28,7 @@ function Base.zero(::Type{Entry})
     return nothing
 end
 
-function randomize!(entry::Entry, rand_function = randn)
+function initialize!(entry::Entry, init_function = randn)
     value = entry.value
-    entry.value = rand_function(eltype(value), size(value))
+    entry.value = init_function(eltype(value), size(value))
 end

src/system/interface.jl

@@ -23,27 +23,27 @@ function ranges(dims::AbstractVector)
     return range_dict
 end
 
-function randomize!(system::System, rand_function = randn)
+function initialize!(system::System, init_function = randn)
     for entry in system.matrix_entries.nzval
-        randomize!(entry, rand_function)
+        initialize!(entry, init_function)
     end
     for entry in system.vector_entries
-        randomize!(entry, rand_function)
+        initialize!(entry, init_function)
     end
 end
 
-function randomize!(system::System{N,<:Symmetric}, rand_function = randn) where N
+function initialize!(system::System{N,<:Symmetric}, init_function = randn) where N
     matrix_entries = system.matrix_entries
 
     for entry in matrix_entries.nzval
-        randomize!(entry, rand_function)
+        initialize!(entry, init_function)
     end
     for i=1:N
         matrix_entries[i,i].value += matrix_entries[i,i].value'
     end
 
     for entry in system.vector_entries
-        randomize!(entry, rand_function)
+        initialize!(entry, init_function)
     end
 end
 

test/interface.jl

@@ -0,0 +1,27 @@
+using GraphBasedSystems
+using LinearAlgebra
+
+include("adjacency_matrix.jl")
+
+system = System{Float64}(A, rand(0:3, size(A)[1]))
+
+children(system, 1)
+connections(system, 1)
+parents(system, 1)
+children(system, 10)
+connections(system, 10)
+parents(system, 10)
+@test true
+
+@test GraphBasedSystems.ranges(system) == GraphBasedSystems.ranges(system.dims)
+
+initialize!(system, rand)
+initialize!(system, randn)
+initialize!(system, ones)
+initialize!(system, zeros)
+
+@test true
+
+reset_inverse_diagonals!(system)
+
+@test true

test/ldlt_test.jl

@@ -7,7 +7,7 @@ include("adjacency_matrix.jl")
 system = System{Float64}(A, rand(0:3, size(A)[1]), symmetric=true)
 
 for i=1:10
-    randomize!(system)
+    initialize!(system)
 
     F = full_matrix(system)
     f = full_vector(system)

test/ldu_test.jl

@@ -7,7 +7,7 @@ include("adjacency_matrix.jl")
 system = System{Float64}(A, rand(0:3, size(A)[1]))
 
 for i=1:10
-    randomize!(system)
+    initialize!(system)
 
     F = full_matrix(system)
     f = full_vector(system)

test/llt_test.jl

@@ -7,7 +7,7 @@ include("adjacency_matrix.jl")
 system = System{Float64}(A, rand(0:3, size(A)[1]), symmetric=true)
 
 for i=1:10
-    randomize!(system)
+    initialize!(system)
     F = full_matrix(system)
     while !isposdef(F)
         for i=1:size(A)[1]

test/lu_test.jl

@@ -7,7 +7,7 @@ include("adjacency_matrix.jl")
 system = System{Float64}(A, rand(0:3, size(A)[1]))
 
 for i=1:10
-    randomize!(system)
+    initialize!(system)
 
     F = full_matrix(system)
     f = full_vector(system)