Benchmarks fix 3

Author: janbruedigam

.gitignore

@@ -1,2 +1,3 @@
 /Manifest.toml
-/testscripts
+/testscripts
+/benchmark/tune.json

benchmark/example_benchmark.jl

@@ -77,21 +77,32 @@ A[13,21] = A[21,13] = 1
 A[16,30] = A[30,16] = 1
 A[20,36] = A[36,20] = 1
 
-
-system = System{Float64}(A, ones(Int,size(A)[1])*6)
-
 function randomize_posdef!(system)
-    randomize!(system)
-    F = full_matrix(system)
-    while !isposdef(F)
-        for i=1:size(A)[1]
-            system.matrix_entries[i,i].value += I 
-        end
-        F = full_matrix(system)
+    randomize!(system,rand)
+    for i=1:size(A)[1]
+        system.matrix_entries[i,i].value += 1000*I 
     end
 end
 
+
+system = System{Float64}(A, ones(Int,size(A)[1])*3)
+systemldlt = System{Float64}(A, ones(Int,size(A)[1])*3, symmetric=true)
+systemllt = System{Float64}(A, ones(Int,size(A)[1])*3, symmetric=true)
+
 SUITE["ldu"] = @benchmarkable ldu_solve!($system) samples=2 setup=(randomize!($system))
 SUITE["lu"] = @benchmarkable lu_solve!($system) samples=2 setup=(randomize!($system))
-SUITE["ldlt"] = @benchmarkable ldlt_solve!($system) samples=2 setup=(randomize!($system))
-SUITE["llt"] = @benchmarkable llt_solve!($system) samples=2 setup=(randomize_posdef!($system))
+SUITE["ldlt"] = @benchmarkable ldlt_solve!($systemldlt) samples=2 setup=(randomize!($systemldlt))
+SUITE["llt"] = @benchmarkable llt_solve!($systemllt) samples=2 setup=(randomize_posdef!($systemllt))
+
+# A = [
+#     0 1 1 1 1
+#     1 0 1 1 1
+#     1 1 0 1 1
+#     1 1 1 0 1
+#     1 1 1 1 0
+# ]
+
+
+
+
+

src/solvers/llt.jl

@@ -16,6 +16,10 @@ function llt_factorization_cyclic!(entry_lu, offdiagonal_lu, offdiagonal_ul)
     entry_lu.value -= offdiagonal_lu.value * offdiagonal_ul.value'
     return
 end
+# TODO currently allocates memory
+function llt_diagonal_root!(diagonal)
+    diagonal.value = sqrt(diagonal.value)
+end
 
 
 function llt_factorization!(system::System)
@@ -36,7 +40,7 @@ function llt_factorization!(system::System)
             end
             llt_factorization_acyclic!(matrix_entries[v,v], matrix_entries[v,c], matrix_entries[c,c], diagonal_inverses[c])
         end
-        matrix_entries[v,v].value = sqrt(matrix_entries[v,v].value)
+        llt_diagonal_root!(matrix_entries[v,v])
     end
     return
 end