Skip to content

Commit 9fdee3b

Browse files
committed
Revert "Disable dlfilter by default"
This reverts commit 923eaef. Closes #260
1 parent 662f689 commit 9fdee3b

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

core/env_vars.ml

+2-4
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,8 @@ let debug = Option.is_some (Unix.getenv "MAGIC_TRACE_DEBUG")
2121
features of magic-trace. *)
2222
let experimental = Option.is_some (Unix.getenv "MAGIC_TRACE_EXPERIMENTAL")
2323

24-
(* magic-trace's dlfilter integration is busted right now, see #246. Also:
25-
26-
When tracing the kernel on certain systems, perf only has root access when
24+
(* When tracing the kernel on certain systems, perf only has root access when
2725
being run with a specific set of flags. Since this does not include
2826
[--dlfilter], this environment variable allows the user to forcibly disable
2927
filtering. *)
30-
let no_dlfilter = Option.is_none (Unix.getenv "MAGIC_TRACE_ENABLE_DLFILTER")
28+
let no_dlfilter = Option.is_some (Unix.getenv "MAGIC_TRACE_NO_DLFILTER")

0 commit comments

Comments
 (0)