Skip to content

Commit d36c159

Browse files
committed
Reap zombie perf processes from capability detection
Closes #315. Signed-off-by: Tudor Brindus <tbrindus@janestreet.com>
1 parent 48b61ef commit d36c159

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/perf_capabilities.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ let detect_exn () =
103103
let%bind perf_version_proc =
104104
Process.create_exn ~prog:Env_vars.perf_path ~args:[ "--version" ] ()
105105
in
106-
let%map version_string = Reader.contents (Process.stdout perf_version_proc) in
107-
let version = Version.of_perf_version_string_exn version_string in
106+
let%map { stdout; _ } = Process.collect_output_and_wait perf_version_proc in
107+
let version = Version.of_perf_version_string_exn stdout in
108108
let set_if bool flag cap = cap + if bool then flag else empty in
109109
empty
110110
|> set_if (supports_configurable_psb_period ()) configurable_psb_period

0 commit comments

Comments
 (0)