-
Notifications
You must be signed in to change notification settings - Fork 31
Use dedicated runtime functions instead of relying on caml_ml_channels explicitly #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hugo Heuzard <[email protected]>
Signed-off-by: Hugo Heuzard <[email protected]>
|
@tkluck-janestreet, @TyOverby, this PR blocks merging ocsigen/js_of_ocaml#1601 (well, we would also need a new ppx_expect release) |
|
hi @hhugo , just to let you know I forwarded this to the right people and they're looking at it. I'm sure they'll post an update here soon. |
|
Hi, I'll submit a new release of This might take some time, as we also need to update our internal version of |
Thank you |
|
There are some timing issues on this as we are using wasm_of_ocaml with some patches and ocsigen/js_of_ocaml#1601 doesn't apply cleanly. I know @vouillon and Tarides folks are looking at getting wasm_of_ocaml up-to-date with jsoo, which would make this change quite straightforward. If that is happening in the next couple weeks then we would rather wait and then apply all of these changes after updating. |
It's apparently not happening in the next couple of weeks |
|
These changes have been released internally and will be part of the next public release. Apologies for the delay here. |
|
Thank you! ocaml/opam-repository#26695 was submitted with this patch. |
This goes with ocsigen/js_of_ocaml#1601 and should allow fixing memory leak of ocaml channels.
We first need a new release of jsoo that include the new api. We can then merge this PR (and release ppx_expect) and finally merge ocsigen/js_of_ocaml#1601