make v0.16 usable with js_of_ocaml GPR 1601 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Contributor
|
Will do. |
github-iron
added
the
forwarded-to-js-devs
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm requesting a minor release of ppx_expect.v0.16 that include #54. This would allow to merge ocsigen/js_of_ocaml#1601 and fully fix the memory leak of ocaml channels reported in ocsigen/js_of_ocaml#1577
The reason we need this for ppx_expect.v0.16 is that jsoo runs its expect tests with OCaml.4.14 and ppx_expect.v0.17 is not compatible with such versions.
@TyOverby, can you monitor this PR so that it doesn't get lost.