Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Commit 8acd5e2

Browse files
committed
fix shortcuts without modifiers beeing detected even when modifier were active
1 parent 25ad979 commit 8acd5e2

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed

src/Widgets/MainWindow.vala

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -554,17 +554,18 @@ public class FeedReader.MainWindow : Gtk.ApplicationWindow
554554
Gdk.ModifierType? mod;
555555
string setting = Settings.keybindings().get_string(gsettingKey);
556556
Gtk.accelerator_parse(setting, out key, out mod);
557+
Logger.debug(gsettingKey);
557558

558559
if(key != null && Gdk.keyval_to_lower(event.keyval) == key)
559560
{
560-
if(mod == null && event.state == 0)
561+
if(mod == null || mod == 0)
561562
{
562-
return true;
563+
if(event.state == 16)
564+
return true;
563565
}
564-
else
566+
else if(mod in event.state)
565567
{
566-
if((event.state & mod) == mod)
567-
return true;
568+
return true;
568569
}
569570
}
570571

@@ -579,31 +580,31 @@ public class FeedReader.MainWindow : Gtk.ApplicationWindow
579580
if(ColumnView.get_default().searchFocused())
580581
return false;
581582

582-
if(checkShortcut(event, "feedlist-prev"))
583+
if(checkShortcut(event, "articlelist-prev"))
583584
{
584-
Logger.debug("shortcut: feedlist prev");
585-
ColumnView.get_default().FeedListPREV();
585+
Logger.debug("shortcut: articlelist prev");
586+
ColumnView.get_default().ArticleListPREV();
586587
return true;
587588
}
588589

589-
if(checkShortcut(event, "feedlist-next"))
590+
if(checkShortcut(event, "articlelist-next"))
590591
{
591-
Logger.debug("shortcut: feedlist next");
592-
ColumnView.get_default().FeedListNEXT();
592+
Logger.debug("shortcut: articlelist next");
593+
ColumnView.get_default().ArticleListNEXT();
593594
return true;
594595
}
595596

596-
if(checkShortcut(event, "articlelist-prev"))
597+
if(checkShortcut(event, "feedlist-prev"))
597598
{
598-
Logger.debug("shortcut: articlelist prev");
599-
ColumnView.get_default().ArticleListPREV();
599+
Logger.debug("shortcut: feedlist prev");
600+
ColumnView.get_default().FeedListPREV();
600601
return true;
601602
}
602603

603-
if(checkShortcut(event, "articlelist-next"))
604+
if(checkShortcut(event, "feedlist-next"))
604605
{
605-
Logger.debug("shortcut: articlelist next");
606-
ColumnView.get_default().ArticleListNEXT();
606+
Logger.debug("shortcut: feedlist next");
607+
ColumnView.get_default().FeedListNEXT();
607608
return true;
608609
}
609610

0 commit comments

Comments
 (0)