Standardize min/max value calls (#902)

Author: E-A-Griffin

test/clojure/core_test/dec.cljc

@@ -24,13 +24,10 @@
       (is (NaN? (dec ##NaN))))
 
     (testing "underflow"
-      #?(:cljr    (is (p/thrown? (dec Int64/MinValue)))
-         :phel    (is (= (dec php/PHP_INT_MIN) (dec php/PHP_INT_MIN)))
+      #?(:phel    (is (= (dec min-int) (dec min-int)))
          :lpy     []  ; Python integers cannot underflow
-         :jank    (is (p/thrown? (dec min-int)))
-         :cljs    (is (= (dec js/Number.MIN_SAFE_INTEGER) (- js/Number.MIN_SAFE_INTEGER 2)))
-         :clj     (is (p/thrown? (dec Long/MIN_VALUE)))
-         :default (is false "TODO underflow")))
+         :cljs    (is (= (dec min-int) (- min-int 2)))
+         :default (is (p/thrown? (dec min-int)))))
 
     (testing "dec-nil"
       ;; ClojureScript says (= -1 (dec nil)) because JavaScript casts null to 0

test/clojure/core_test/inc.cljc

@@ -25,14 +25,11 @@
       (is (NaN? (inc ##NaN))))
 
     (testing "overflow"
-      #?(:cljr (is (p/thrown? (inc Int64/MaxValue)))
-         ;; Phel integers avoid overflow by being promoted to BigInteger
-         :phel (is (not (= (inc php/PHP_INT_MAX) (+ 2 php/PHP_INT_MAX))))
+      #?(;; Phel integers avoid overflow by being promoted to BigInteger
+         :phel (is (not (= (inc max-int) (+ 2 max-int))))
          :lpy nil  ; Python integers cannot overflow
-         :jank (is (p/thrown? (inc max-int)))
-         :cljs (is (= (inc js/Number.MAX_SAFE_INTEGER) (+ 2 js/Number.MAX_SAFE_INTEGER)))
-         :clj (is (p/thrown? (inc Long/MAX_VALUE)))
-         :default (is false "overflow untested")))
+         :cljs (is (= (inc max-int) (+ 2 max-int)))
+         :default (is (p/thrown? (inc max-int)))))
 
     (testing "inc-nil"
       ;; ClojureScript says (= 1 (inc nil)) because JavaScript casts null to 0