add codemirror error message

Author: Jannes

README.md

@@ -2,6 +2,8 @@
 
 Conntect Zotero with Joplin to reference sources in notes and open them via `zotero://` links.
 
+When having trouble using this plugin, please have a look down below to the FAQ.
+
 ## Installation
 
 ### Zotero >= 7
@@ -55,6 +57,10 @@ Custom formattting of the text can be enabled from plugin settings.
 
 ## FAQ
 
-### Zotero crashes after installation
+### Joplin crashes after installation
+
+- using CodeMirror v5 (only supported up to v1.2.1) (#17, #18, #20, #22)
+
+### No Zotero Data could be loaded
 
-Please have a look at this [issues](https://github.com/jannessm/joplin-zotero-link/issues/20), if it helps. Otherwise create a new one.
+- check if the port is correct under the plugin settings (#3, #4, #6)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "joplin-plugin-zotero-link",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "scripts": {
     "dist": "webpack --env joplin-plugin-config=buildMain && webpack --env joplin-plugin-config=buildExtraScripts && webpack --env joplin-plugin-config=createArchive",
     "prepare": "npm run dist",

src/manifest.json

@@ -2,7 +2,7 @@
 	"manifest_version": 1,
 	"id": "nz.magnusso.zotero-link",
 	"app_min_version": "2.12",
-	"version": "2.1.1",
+	"version": "2.1.2",
 	"name": "Zotero Link",
 	"description": "Link Zotero entries in notes",
 	"author": "Jannes Magnusson",

src/zotero-link.ts

@@ -9,16 +9,22 @@ module.exports = {
                 if (!value) return;
                 const zq = new ZoteroQuery(context, cm);
 
-                console.log(CodeMirror);
-                CodeMirror.addExtension([
-                    CodeMirror.joplinExtensions.completionSource(
-                      zq.getCompletions()
-                    ),
-                    
-                    // Joplin also exposes a Facet that allows enabling or disabling CodeMirror's
-                    // built-in autocompletions. These apply, for example, to HTML tags.
-                    CodeMirror.joplinExtensions.enableLanguageDataAutocomplete.of(true)
-                ]);
+                try {
+                    CodeMirror.addExtension([
+                        CodeMirror.joplinExtensions.completionSource(
+                          zq.getCompletions()
+                        ),
+                        
+                        // Joplin also exposes a Facet that allows enabling or disabling CodeMirror's
+                        // built-in autocompletions. These apply, for example, to HTML tags.
+                        CodeMirror.joplinExtensions.enableLanguageDataAutocomplete.of(true)
+                    ]);
+                } catch {
+                    this.context.postMessage({
+                        title: 'Zotero Link could not be initialized.',
+                        description: 'You are probably using a CodeMirror v5 which is only supported by ZoteroLink<=1.2.1.'
+                    });
+                }
             });
         };
 

src/zotero-query.ts

@@ -60,25 +60,27 @@ export class ZoteroQuery {
 
         let data;
 
-        try {
-            data = await this.tryZotero7(settings.port);
+        data = await this.tryZotero7(settings.port);
+
+        // zotero api is not working. Try to use zotserver
+        if (!data) {
+            data = await this.tryZotServer(settings.port);
+        }
+
+        if (!!data) {
+            data = data.filter(item => item.itemType !== 'attachment' && item.itemType !== 'note')
+                .map(item => new ZoteroItem(item, settings.customFormat));
 
-            // zotero api is not working. Try to use zotserver
-            if (!data) {
-                data = await this.tryZotServer(settings.port);
-            }
-        } catch {
+            data.sort((a: ZoteroItem, b: ZoteroItem) => a.title.localeCompare(b.title));
+            return data;
+        } else {
             this.context.postMessage({
                 title: 'Loading Zotero data failed.',
                 description: 'Data could not be loaded from Zotero. Please check if Zotero is running with the correct port set in your settings. Otherwise a broken reference in your library could be an issue. Please have a look at existing github issues to find more help.'
             });
-        }
-
-        data = data.filter(item => item.itemType !== 'attachment' && item.itemType !== 'note')
-            .map(item => new ZoteroItem(item, settings.customFormat));
 
-        data.sort((a: ZoteroItem, b: ZoteroItem) => a.title.localeCompare(b.title));
-        return data;
+            return [];
+        }
     }
 
     async tryZotero7(port: string){