forked from argoproj-labs/argocd-agent
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathevent_writer.go
More file actions
586 lines (492 loc) · 14.9 KB
/
Copy pathevent_writer.go
File metadata and controls
586 lines (492 loc) · 14.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
package event
import (
"context"
"sync"
"time"
"github.com/argoproj-labs/argocd-agent/internal/grpcutil"
"github.com/argoproj-labs/argocd-agent/internal/logging"
"github.com/argoproj-labs/argocd-agent/internal/logging/logfields"
"github.com/argoproj-labs/argocd-agent/pkg/api/grpc/eventstreamapi"
format "github.com/cloudevents/sdk-go/binding/format/protobuf/v2"
cloudevents "github.com/cloudevents/sdk-go/v2"
"github.com/sirupsen/logrus"
"k8s.io/apimachinery/pkg/util/wait"
)
const (
// maxEventRetries is the maximum number of times an event will be retried before giving up.
maxEventRetries = 12
)
type streamWriter interface {
Send(*eventstreamapi.Event) error
Context() context.Context
}
// EventWriter keeps track of the latest event for resources and sends them on a given gRPC stream.
// It resends the event with exponential backoff until the event is ACK'd and removed from its list.
type EventWriter struct {
mu sync.RWMutex
// key: resource name + UID
// value: queue of unsent events for a resource
// - acquire 'lock' before accessing
unsentEvents map[string]*eventQueue
// key: resource name + UID
// value: sent event waiting for ACK
// - acquire 'lock' before accessing
sentEvents map[string]*eventMessage
// target refers to the specified gRPC stream.
target streamWriter
// agentName is the name of the agent for which this EventWriter is responsible.
agentName string
// onRetryExhausted is called once per resource when an event is dropped after
// exceeding maxEventRetries (optional; used for metrics).
onRetryExhausted func(resourceID string)
log *logrus.Entry
}
// EventWriterOption configures an EventWriter.
type EventWriterOption func(*EventWriter)
// WithOnRetryExhausted registers a callback invoked when a sent event is removed
// after exhausting retries. resourceID is the map key (not used as a metric label).
func WithOnRetryExhausted(fn func(resourceID string)) EventWriterOption {
return func(ew *EventWriter) {
ew.onRetryExhausted = fn
}
}
type eventMessage struct {
// when this lock is owned, never attempt to THEN acquire `eventWriter.mu`, as this will lead to a deadlock.
// If you require `eventWriter.mu`, you must acquire that lock FIRST, before attempting to acquiring `mu` (to avoid deadlock)
mu sync.RWMutex
// latest event for a resource
// - acquire 'lock' before accessing
event *cloudevents.Event
// retry sending the event after this time
retryAfter *time.Time
// config for exponential backoff
backoff *wait.Backoff
// track number of retries attempted
retryCount int
}
// NewEventWriter creates a new EventWriter for the given target stream.
// If you create an EventWriter targeting the principal, an empty agentName
// should be used.
func NewEventWriter(agentName string, target streamWriter, opts ...EventWriterOption) *EventWriter {
ew := &EventWriter{
unsentEvents: map[string]*eventQueue{},
sentEvents: map[string]*eventMessage{},
target: target,
agentName: agentName,
log: logging.GetDefaultLogger().ModuleLogger("EventWriter").WithField(logfields.ClientAddr, grpcutil.AddressFromContext(target.Context())).WithField(logfields.Agent, agentName),
}
for _, o := range opts {
o(ew)
}
return ew
}
func (ew *EventWriter) UpdateTarget(target streamWriter) {
ew.mu.Lock()
defer ew.mu.Unlock()
ew.target = target
ew.log = logging.GetDefaultLogger().ModuleLogger("EventWriter").
WithField(logfields.ClientAddr, grpcutil.AddressFromContext(target.Context())).
WithField(logfields.Agent, ew.agentName)
// Reset retry timers so events in sentEvents are retried immediately on the new connection.
// This is important for reconnection scenarios where the old connection died
// and ACKs will never arrive, so we want to give events a fresh chance on the new stream.
now := time.Now()
for _, msg := range ew.sentEvents {
msg.mu.Lock()
msg.retryAfter = &now
msg.mu.Unlock()
}
}
func (ew *EventWriter) Add(ev *cloudevents.Event) {
resID := ResourceID(ev)
ew.mu.Lock()
defer ew.mu.Unlock()
logCtx := ew.log.WithFields(logrus.Fields{
"resource_id": ResourceID(ev),
"event_id": EventID(ev),
"type": ev.Type(),
})
defaultBackoff := wait.Backoff{
Steps: maxEventRetries,
Duration: 1 * time.Second,
Factor: 1.5,
Jitter: 0.1,
}
if resID == "" {
logCtx.Error("resID was empty")
return
}
// Once an app is being deleted, no other updates matter
if ev.Type() == Delete.String() {
delete(ew.sentEvents, resID)
// Clear any existing unsent events and add only the DELETE event
eq := newEventQueue()
eq.add(&eventMessage{
event: ev,
backoff: &defaultBackoff,
})
ew.unsentEvents[resID] = eq
logCtx.Trace("cleared all events and added DELETE event")
return
}
// Add to unsent queue with coalescing logic
eq, exists := ew.unsentEvents[resID]
if !exists {
eq = newEventQueue()
eq.add(&eventMessage{
event: ev,
backoff: &defaultBackoff,
})
ew.unsentEvents[resID] = eq
logCtx.Trace("added a new event to the event writer")
return
}
// The queue's add() coalesces events of the same type.
eq.add(&eventMessage{
event: ev,
backoff: &defaultBackoff,
retryAfter: nil,
})
logCtx.Trace("updated an existing event in the event writer")
}
func (ew *EventWriter) Get(resID string) *eventMessage {
ew.mu.RLock()
defer ew.mu.RUnlock()
// First check sent events (for retry)
if sent, exists := ew.sentEvents[resID]; exists {
return sent
}
// Then check unsent queue
if eq, exists := ew.unsentEvents[resID]; exists {
return eq.get()
}
return nil
}
// ObserveSentResendState calls observer with counts derived from sentEvents:
// sentPending is len(sentEvents); resendDue is entries whose retryAfter is nil
// or not after now; resendBackoff is sentPending - resendDue.
// Lock order: EventWriter.mu RLock, then each eventMessage.mu RLock.
func (ew *EventWriter) ObserveSentResendState(observer func(sentPending, resendDue, resendBackoff int)) {
now := time.Now()
ew.mu.RLock()
pending := len(ew.sentEvents)
due := 0
for _, msg := range ew.sentEvents {
msg.mu.RLock()
ra := msg.retryAfter
msg.mu.RUnlock()
if ra == nil || !ra.After(now) {
due++
}
}
ew.mu.RUnlock()
backoff := pending - due
observer(pending, due, backoff)
}
func (ew *EventWriter) Remove(ev *cloudevents.Event) {
ew.mu.Lock()
defer ew.mu.Unlock()
// Remove the event only if it matches both the resourceID and eventID.
resourceID := ResourceID(ev)
incomingEventID := EventID(ev)
// First, check and remove from sent events
if sent, exists := ew.sentEvents[resourceID]; exists {
sent.mu.RLock()
sentEventID := EventID(sent.event)
sent.mu.RUnlock()
if sentEventID == incomingEventID {
delete(ew.sentEvents, resourceID)
return
}
}
// If not in sent events, check unsent queue
eq, exists := ew.unsentEvents[resourceID]
if !exists {
return
}
front := eq.get()
if front == nil {
return
}
front.mu.RLock()
frontEventID := EventID(front.event)
front.mu.RUnlock()
if frontEventID == incomingEventID {
eq.pop()
if eq.isEmpty() {
delete(ew.unsentEvents, resourceID)
}
}
}
// SendWaitingEvents will periodically send the events waiting in the EventWriter.
// Note: This function will never return unless the context is done, and therefore
// should be started in a separate goroutine.
func (ew *EventWriter) SendWaitingEvents(ctx context.Context) {
ew.mu.RLock()
logCtx := ew.log
ew.mu.RUnlock()
logCtx.Info("Starting event writer")
for {
select {
case <-ctx.Done():
logCtx.Info("Shutting down event writer")
return
default:
ew.mu.RLock()
// Collect all resource IDs that have either unsent or sent events
resourceIDs := make([]string, 0, len(ew.unsentEvents)+len(ew.sentEvents))
for resID := range ew.unsentEvents {
resourceIDs = append(resourceIDs, resID)
}
for resID := range ew.sentEvents {
// Only add if not already in the list
if _, exists := ew.unsentEvents[resID]; !exists {
resourceIDs = append(resourceIDs, resID)
}
}
ew.mu.RUnlock()
for _, resourceID := range resourceIDs {
ew.sendEvent(resourceID)
}
}
time.Sleep(100 * time.Millisecond)
}
}
// sendEvent determines whether to retry a sent event or send a new unsent event
func (ew *EventWriter) sendEvent(resID string) {
// Check if there's a sent event awaiting retry
ew.mu.RLock()
sentMsg, hasSent := ew.sentEvents[resID]
ew.mu.RUnlock()
if hasSent {
ew.retrySentEvent(resID, sentMsg)
} else {
ew.sendUnsentEvent(resID)
}
}
// retrySentEvent handles retrying an event that was already sent but not yet acknowledged
func (ew *EventWriter) retrySentEvent(resID string, sentMsg *eventMessage) {
ew.mu.RLock()
logCtx := ew.log.WithFields(logrus.Fields{
"method": "retrySentEvent",
"resource_id": resID,
})
// Re-verify the event is still in sentEvents
currentSent, stillExists := ew.sentEvents[resID]
ew.mu.RUnlock()
// If event was ACK'd between check and use, skip retry
if !stillExists || currentSent != sentMsg {
return
}
sentMsg.mu.Lock()
// Check if it's time to retry
if sentMsg.retryAfter != nil && sentMsg.retryAfter.After(time.Now()) {
sentMsg.mu.Unlock()
return
}
logCtx = logCtx.WithFields(logrus.Fields{
"event_id": EventID(sentMsg.event),
"event_target": sentMsg.event.DataSchema(),
"event_type": sentMsg.event.Type(),
"retry_count": sentMsg.retryCount,
})
// Check if we've exhausted retries
if sentMsg.retryCount >= maxEventRetries {
logCtx.Warnf("Event failed after %d retries, giving up to unblock queue", sentMsg.retryCount)
sentMsg.mu.Unlock()
ew.mu.Lock()
if cur, ok := ew.sentEvents[resID]; ok && cur == sentMsg {
if ew.onRetryExhausted != nil {
ew.onRetryExhausted(resID)
}
delete(ew.sentEvents, resID)
}
ew.mu.Unlock()
return
}
logCtx.Trace("resending an event")
// Increment retry count and schedule next retry BEFORE attempting send
// This ensures proper backoff even when the send fails
sentMsg.retryCount++
retryAfter := time.Now().Add(sentMsg.backoff.Step())
sentMsg.retryAfter = &retryAfter
// Resend the event
pev, err := format.ToProto(sentMsg.event)
if err != nil {
logCtx.Errorf("Could not wire event: %v\n", err)
sentMsg.mu.Unlock()
return
}
err = ew.target.Send(&eventstreamapi.Event{Event: pev})
sentMsg.mu.Unlock()
if err != nil {
logCtx.Errorf("Error while sending: %v\n", err)
return
}
logCtx.Trace("event sent to target")
}
// scheduleRetry sets the next retry time for an event using exponential backoff
func (ew *EventWriter) scheduleRetry(eventMsg *eventMessage) {
eventMsg.mu.Lock()
defer eventMsg.mu.Unlock()
retryAfter := time.Now().Add(eventMsg.backoff.Step())
eventMsg.retryAfter = &retryAfter
}
// sendUnsentEvent pops an event from the unsent queue and sends it for the first time
func (ew *EventWriter) sendUnsentEvent(resID string) {
ew.mu.Lock()
logCtx := ew.log.WithFields(logrus.Fields{
"method": "sendUnsentEvent",
"resource_id": resID,
})
// Pop event from unsent queue and atomically move to sent tracker
eq, exists := ew.unsentEvents[resID]
if !exists || eq.isEmpty() {
ew.mu.Unlock()
return
}
eventMsg := eq.pop()
if eq.isEmpty() {
delete(ew.unsentEvents, resID)
}
if eventMsg == nil {
ew.mu.Unlock()
return
}
target := Target(eventMsg.event)
isFireAndForget := target == TargetEventAck || target == TargetHeartbeat
if !isFireAndForget {
// IMPORTANT: Set retryAfter *before* publishing into sentEvents.
// We can have concurrent SendWaitingEvents loops (e.g. brief overlap during reconnect),
// and without this, another goroutine can observe retryAfter==nil and immediately retry,
// causing duplicate sends within the same second.
//
// Retry behavior:
// On success: retry happens if ACK never arrives
// On failure: retry happens after backoff
ew.scheduleRetry(eventMsg)
ew.sentEvents[resID] = eventMsg
}
ew.mu.Unlock()
// Send the event
eventMsg.mu.Lock()
logCtx = logCtx.WithFields(logrus.Fields{
"event_id": EventID(eventMsg.event),
"event_target": eventMsg.event.DataSchema(),
"event_type": eventMsg.event.Type(),
})
if !isFireAndForget {
SetSentAt(eventMsg.event)
}
pev, err := format.ToProto(eventMsg.event)
eventMsg.mu.Unlock()
if err != nil {
logCtx.Errorf("Could not wire event: %v\n", err)
return
}
// A Send() on the stream is actually not blocking.
err = ew.target.Send(&eventstreamapi.Event{Event: pev})
if err != nil {
logCtx.Errorf("Error while sending: %v\n", err)
return
}
logCtx.Trace("event sent to target")
if isFireAndForget {
logCtx.Trace("Fire-and-forget event (ACK or heartbeat) removed from event writer")
}
}
// eventWritersMap provides a thread-safe way to manage event writers.
type EventWritersMap struct {
mu sync.RWMutex
// key: AgentName
// value: EventWriter for that agent
// - acquire 'lock' before accessing
eventWriters map[string]*EventWriter
}
func NewEventWritersMap() *EventWritersMap {
return &EventWritersMap{
eventWriters: make(map[string]*EventWriter),
}
}
func (ewm *EventWritersMap) Get(agentName string) *EventWriter {
ewm.mu.RLock()
defer ewm.mu.RUnlock()
eventWriter, exists := ewm.eventWriters[agentName]
if exists {
return eventWriter
}
return nil
}
func (ewm *EventWritersMap) Add(agentName string, eventWriter *EventWriter) {
ewm.mu.Lock()
defer ewm.mu.Unlock()
ewm.eventWriters[agentName] = eventWriter
}
func (ewm *EventWritersMap) Remove(agentName string) {
ewm.mu.Lock()
defer ewm.mu.Unlock()
delete(ewm.eventWriters, agentName)
}
// ObserveWriters calls fn for each agent name and EventWriter while holding a read lock on the map.
func (ewm *EventWritersMap) ObserveWriters(fn func(agentName string, ew *EventWriter)) {
ewm.mu.RLock()
defer ewm.mu.RUnlock()
for name, w := range ewm.eventWriters {
fn(name, w)
}
}
// eventQueue is a queue of eventMessages where the items are coalesced by type.
type eventQueue struct {
mu sync.RWMutex
items []*eventMessage
}
func newEventQueue() *eventQueue {
return &eventQueue{
items: []*eventMessage{},
}
}
// add an item to the tail of the queue.
// If the item is the same type as the tail, replace the tail with the new item.
func (eq *eventQueue) add(ev *eventMessage) {
eq.mu.Lock()
defer eq.mu.Unlock()
if len(eq.items) > 0 {
tail := eq.items[len(eq.items)-1]
tail.mu.Lock()
// Replace an older event with a newer one of the same type
if ev.event.Type() == tail.event.Type() {
tail.event = ev.event
tail.backoff = ev.backoff
tail.retryAfter = ev.retryAfter
tail.mu.Unlock()
return
}
tail.mu.Unlock()
}
eq.items = append(eq.items, ev)
}
// get the first item from the queue.
func (eq *eventQueue) get() *eventMessage {
eq.mu.RLock()
defer eq.mu.RUnlock()
if len(eq.items) == 0 {
return nil
}
return eq.items[0]
}
// pop the first item from the queue.
func (eq *eventQueue) pop() *eventMessage {
eq.mu.Lock()
defer eq.mu.Unlock()
if len(eq.items) == 0 {
return nil
}
item := eq.items[0]
eq.items = eq.items[1:]
return item
}
func (eq *eventQueue) isEmpty() bool {
eq.mu.RLock()
defer eq.mu.RUnlock()
return len(eq.items) == 0
}