Various dice rolls not possible for PCs when TH is loaded

[Weissrolf]

Hello.

Several of my players were not able to do rolls from their char sheet or Token Action HUD today (like skill rolls). It changed which player was able or not, but it reproducible was solved by unloading Token Hotbar.

v9 + PF2E system

[janssen-io]

Hi! Thanks for the report again. I'll be looking into these issues this week. :)

[janssen-io]

I'm unable to reproduce this with just Token Hotbar and Token Action HUD. Do you have any specific information about the rolls or players? Are there any errors appearing in the console (F12)?

Would it be possible to share your world with me?

[Weissrolf]

The rolls were just trying to click on skill via sheet tab or on strikes via Token Action HUD. No roll would happen (no reaction to click). As a GM I was always able to do the click for the players that were affected at any time.

A total of 6 players where connected (+GM) and with reloads the players being affected sometimes changed. I suspect the number of logged in players may affect this.

I used "Find the culprit" and had my players do one roll each after every reload of FtC and in the end only Token Hotbar was left in combination with: libWrapper, lib - Color Settings, Library: DF Hotkeys, socketlib and TidyUI - Game Settings.

[janssen-io]

More users have experienced this issue.

[Nhaaro]

My players just experienced this issue as well, this is the error shown in the console, although it doesn't say much

I can sort of reproduce it, so let me know if there's more info that could be useful

Edit: this is the same error, but on Firefox, I feel this gives a little more info

[Nhaaro]

after a bit of digging I think I found the issue, seems to be some conflict with PF2e Player Settings defaults

steps to reproduce: (FoundryVTT v9.269, PF2E v3.10.4.11747, Token Hotbar v1.3.1)

1. Create World with Pathfinder 2nd Edition system
2. Join world as Gamemaster
3. Enable Token Hotbar
4. Create blank Scene
5. Create Player Character actor, don't fill it in
6. Move token into scene
7. Open token Character Sheet (double click on token, not on actor in sidebar)
8. Roll any skill (e.g. Perception located in sidebar)

ERROR SHOULD BE VISIBLE in console and no roll should be possible from that user by clicking any dice button

in order to fix this, the following should be done:

1. Refresh page, this returns the flags to the user
2. Make sure token is not selected
3. Navigate to Game Settings
4. Open PF2e Player Settings
5. Save configuration, no need to modify anything, the defaults work just fine

ERROR SHOULD GO AWAY and never returns

---

the line causing this seems to be

foundry-tokenhotbar-js/src/features.mjs

Line 86 in a48b93f

user.data.update({ hotbar: hotbarForToken || {} }, { recursive: false });

for some reason it's removing the flags from the user, but only the ones set from defaults as far as I can tell, it could be a bug in either pf2e system or foundry

[janssen-io]

Thank you so much for figuring this out! It might have to do with the recursive: false flag I pass along. Not sure what is the right way to fix this, but I’ll discuss in on the community discord channel. :) To be continued 😀

[Weissrolf]

Just to report back: this is still happening, so I disabled the module again.

[janssen-io]

Thanks for the update Weissrolf. Unfortunately, I haven't been able to come up with a solution just yet. I just asked for support on Discord (module-development channel). When there's an update, I'll report back here. :)