-
Notifications
You must be signed in to change notification settings - Fork 8
Description
Feature Request: support merged manifests
Problem Description
When using winget download to download those packages, the downloaded package contains a manifest file with ManifestType set to merged, which cannot be recognized by rewinged with the following error message.
{
"level":"error",
"package":"Microsoft.VisualStudioCode",
"packageversion":"1.100.2",
"time":"2025-05-26T05:08:04Z",
"message":"merged manifests are not yet supported"
}Merged manifests may come from packages with multiple manifest files, take VS Code as a example, which includes manifests of type version, defaultLocale, and installer.
I try to manually update the ManifestType from merged to singleton, which works for some packages, e.g., Microsoft.Edge, and voidtools.Everything. But for some packages, e.g., Google.Chrome, this does not work with error message:
{
"level":"error",
"error":"unsupported SingletonManifest version 1.10.0",
"package":"Google.Chrome",
"packageversion":"137.0.7151.41",
"time":"2025-05-26T05:24:35Z",
"message":"could not parse singleton manifest"
}Note: This problem is related to not yet supporting schema version 1.10.0. After replacing 1.10.0 with 1.9.0, the problem is solved.
Thus, the cause of this problem is not about "rewinged could not parse the singleton manifest".
Suggested Change
- The "merged" type of manifest can be treated as a singleton manifest adding some metadata and locale data, so support for this type of manifest might be intuitive.
- Even if there might be some extra work to support the "merged" type, a fallback mechanism may be early adopted to treat this type as a singleton manifest by ignoring unknown fields.