style: add exportloopref, gocritic, godot & goimports linters + fixes

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>

Author: maxatome

.travis.yml

@@ -32,7 +32,19 @@ script:
   - go test -race $GO_TEST_OPTS ./...
   - >
     if [ "$USE_LINTER" = 1 ]; then
-      golangci-lint run -E gofmt -E golint -E maligned -E misspell -E prealloc -E unconvert -E whitespace ./...;
+      golangci-lint run --max-issues-per-linter 0 \
+                        --max-same-issues 0 \
+                        -E exportloopref \
+                        -E gocritic \
+                        -E godot \
+                        -E goimports \
+                        -E golint \
+                        -E maligned \
+                        -E misspell \
+                        -E prealloc \
+                        -E unconvert \
+                        -E whitespace \
+                        ./...;
     fi
 
 notifications:

transport.go

@@ -162,13 +162,11 @@ func (m *MockTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 			m.callCountInfo[respKey]++
 		}
 		m.totalCallCount++
-	} else {
+	} else if m.noResponder != nil {
 		// we didn't find a responder, so fire the 'no responder' responder
-		if m.noResponder != nil {
-			m.callCountInfo[internal.NoResponder]++
-			m.totalCallCount++
-			responder = m.noResponder
-		}
+		m.callCountInfo[internal.NoResponder]++
+		m.totalCallCount++
+		responder = m.noResponder
 	}
 	m.mu.Unlock()
 
@@ -178,7 +176,7 @@ func (m *MockTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 	return runCancelable(responder, internal.SetSubmatches(req, submatches))
 }
 
-// NumResponders
+// NumResponders returns the number of responders currently in use.
 func (m *MockTransport) NumResponders() int {
 	m.mu.RLock()
 	defer m.mu.RUnlock()
@@ -547,7 +545,7 @@ var DefaultTransport = NewMockTransport()
 var InitialTransport = http.DefaultTransport
 
 // oldClients is used to handle custom http clients (i.e clients other
-// than http.DefaultClient)
+// than http.DefaultClient).
 var oldClients = map[*http.Client]http.RoundTripper{}
 
 // Activate starts the mock environment.  This should be called before

util_test.go

@@ -60,7 +60,8 @@ func writeFile(t *testing.T, file string, content []byte) {
 	}
 }
 
-// All this stuff to compensate the absence of (*testing.T).Helper() in go<1.9
+// fakeHelper allows to compensate the absence of
+// (*testing.T).Helper() in go<1.9.
 type fakeHelper struct{}
 
 func (f fakeHelper) Helper() {}