Skip to content

Commit 65c5590

Browse files
committed
Self contained sticky-header, don't rely on wrapper classname
1 parent d587b6d commit 65c5590

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

assets/base.css

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -369,14 +369,15 @@ pre {
369369
/**
370370
* Header
371371
*/
372-
.section-header {
373-
background-color: #fff;
374-
top: 0;
375-
z-index: 10;
372+
sticky-header {
373+
display: block;
376374
}
377375

378376
.sticky-header-hidden,
379377
.sticky-header-stuck {
378+
position: sticky;
379+
top: 0;
380+
z-index: 10;
380381
transition: all var(--duration-medium) ease-out;
381382
}
382383

assets/global.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,10 @@ class StickyHeader extends HTMLElement {
104104

105105
connectedCallback() {
106106
this.header =
107-
this.querySelector('.section-header') ||
108-
this.closest('.section-header') ||
109-
document.querySelector('.section-header');
107+
this.querySelector('[data-sticky-header-target]') || this.firstElementChild;
110108

111109
if (!this.header) {
112-
console.warn('StickyHeader: .section-header element not found.');
110+
console.warn('StickyHeader: no sticky target found inside the component.');
113111
return;
114112
}
115113

sections/header.liquid

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% render 'search-dialog-modal' %}
22
<sticky-header>
3-
<header class="flex justify-between items-center px-4 py-2 text-center border-b md:py-4 md:px-8">
3+
<header data-sticky-header-target class="flex justify-between items-center px-4 py-2 text-center border-b md:py-4 md:px-8 bg-white">
44
{%- if template.name == 'index' -%}
55
<h1 class="m-0 text-base" itemscope itemtype="http://schema.org/Organization">
66
{%- else -%}
@@ -67,7 +67,6 @@
6767
{% schema %}
6868
{
6969
"name": "Header",
70-
"class": "section-header",
7170
"settings": [
7271
{
7372
"type": "link_list",

0 commit comments

Comments
 (0)