Skip to content

Commit 01f4bd0

Browse files
author
Jonathan Como
committed
Merge pull request #88 from jarus/python-34-unicode-fix
Fix test runs for Python 3.4+
2 parents f3f49e9 + 465dbd3 commit 01f4bd0

File tree

4 files changed

+22
-6
lines changed

4 files changed

+22
-6
lines changed

.travis.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
language: python
22
python:
3+
- "3.5"
4+
- "3.4"
35
- "3.3"
46
- "2.7"
57
- "2.6"
@@ -13,6 +15,14 @@ matrix:
1315
env: FLASK=0.9
1416
- python: "3.3"
1517
env: FLASK=0.8.1
18+
- python: "3.4"
19+
env: FLASK=0.9
20+
- python: "3.4"
21+
env: FLASK=0.8.1
22+
- python: "3.5"
23+
env: FLASK=0.9
24+
- python: "3.5"
25+
env: FLASK=0.8.1
1626
install:
1727
- pip install flask==$FLASK coverage --use-mirrors
1828
- pip install -e . --use-mirrors
@@ -21,3 +31,4 @@ script:
2131
notifications:
2232
email:
2333
34+

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
]
2424

2525
if sys.version_info[0] < 3:
26-
tests_require.append('twill==0.9')
26+
tests_require.append('twill==0.9.1')
2727

2828
if sys.version_info < (2, 6):
2929
tests_require.append('simplejson')

tests/__init__.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,22 @@
22

33
from flask_testing import is_twill_available
44

5-
from .test_utils import TestSetup, TestSetupFailure, TestClientUtils, TestLiveServer, TestTeardownGraceful
65
from .test_twill import TestTwill, TestTwillDeprecated
6+
from .test_utils import TestSetup, TestSetupFailure, TestClientUtils, \
7+
TestLiveServer, TestTeardownGraceful, TestRenderTemplates, \
8+
TestNotRenderTemplates, TestRestoreTheRealRender
79

810

911
def suite():
1012
suite = unittest.TestSuite()
1113
suite.addTest(unittest.makeSuite(TestSetup))
1214
suite.addTest(unittest.makeSuite(TestSetupFailure))
13-
suite.addTest(unittest.makeSuite(TestTeardownGraceful))
1415
suite.addTest(unittest.makeSuite(TestClientUtils))
1516
suite.addTest(unittest.makeSuite(TestLiveServer))
17+
suite.addTest(unittest.makeSuite(TestTeardownGraceful))
18+
suite.addTest(unittest.makeSuite(TestRenderTemplates))
19+
suite.addTest(unittest.makeSuite(TestNotRenderTemplates))
20+
suite.addTest(unittest.makeSuite(TestRestoreTheRealRender))
1621
if is_twill_available:
1722
suite.addTest(unittest.makeSuite(TestTwill))
1823
suite.addTest(unittest.makeSuite(TestTwillDeprecated))

tests/test_utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ def create_app(self):
201201
def test_assert_not_process_the_template(self):
202202
response = self.client.get("/template/")
203203

204-
assert "" == response.data
204+
assert len(response.data) == 0
205205

206206
def test_assert_template_rendered_signal_sent(self):
207207
self.client.get("/template/")
@@ -219,7 +219,7 @@ def create_app(self):
219219
def test_assert_not_process_the_template(self):
220220
response = self.client.get("/template/")
221221

222-
assert "" != response.data
222+
assert len(response.data) > 0
223223

224224

225225
class TestRestoreTheRealRender(TestCase):
@@ -236,4 +236,4 @@ def test_assert_the_real_render_template_is_restored(self):
236236

237237
response = self.client.get("/template/")
238238

239-
assert "" != response.data
239+
assert len(response.data) > 0

0 commit comments

Comments
 (0)