fix: update protobuf and grpcio-tools versions in requirements-tools.txt; improve pylint configuration and check-protobuf workflow

Author: jasonacox

.github/workflows/check-protobuf.yml

@@ -34,7 +34,7 @@ jobs:
 
       - name: Check for uncommitted changes
         run: |
-          git diff --exit-code -- '*_pb2.py' || {
+          git diff --exit-code -- '**/*_pb2.py' || {
             echo ""
             echo "ERROR: pb2 files are out of date with their .proto sources."
             echo "Run the protoc commands above locally and commit the updated pb2 files."

.pre-commit-config.yaml

@@ -12,8 +12,8 @@ repos:
       - id: pylint-pypowerwall
         name: Pylint (pypowerwall errors)
         language: system
-        entry: pylint -E pypowerwall/*.py
-        files: ^pypowerwall/[^/]+\.py$
+        entry: pylint -E pypowerwall/
+        files: ^pypowerwall/.*\.py$
         pass_filenames: false
 
       - id: pylint-proxy

tools/gen_proto.sh

@@ -19,13 +19,12 @@
 #   pip install -r tools/requirements-tools.txt
 #
 # IMPORTANT - VERSION PINNING:
-#   The generated pb2 files embed the exact protobuf version used to generate
-#   them (see ValidateProtobufRuntimeVersion in each pb2 file). The floor in
-#   requirements.txt and setup.py MUST match this version exactly.
-#   tools/requirements-tools.txt pins the generator to protobuf 5.x so that
-#   the library can be used by anyone with protobuf>=5.29.0.
+#   tools/requirements-tools.txt currently pins the generator to protobuf
+#   4.25.x, and the generated pb2 files currently target protobuf>=4.25.1.
+#   (protobuf 4.25.x does NOT embed ValidateProtobufRuntimeVersion, so any
+#   4.x runtime is compatible — but 5.x is not.)
 #   If you upgrade tools/requirements-tools.txt you MUST also update the
-#   protobuf floor in requirements.txt and setup.py to match.
+#   protobuf floor/cap in requirements.txt and setup.py to stay aligned.
 #
 # USAGE:
 #   bash tools/gen_proto.sh

tools/requirements-tools.txt

@@ -14,5 +14,5 @@
 #   2. Update protobuf floor in requirements.txt and setup.py to match the
 #      "Protobuf Python Version" comment in any regenerated pb2 file.
 #   3. Consider whether the upgrade is a breaking change for library users.
-grpcio-tools>=1.60.0,<1.64.0
-protobuf>=4.25.0,<5
+grpcio-tools==1.62.3
+protobuf==4.25.1