Skip to content

Commit 4153a8b

Browse files
committed
userguide/Makefile: don't add "install" to EXTRA_DIST
Adding the directory "install" to EXTRA_DIST, actually triggers make to run "make install", which is not what we want. Instead, avoid this magic keyword and list the files in the install directory individually. If the user doesn't have permission to install files to the prefix, like "/usr", then "make dist" can fail. Worse, even they do have permission to write into the prefix, a "make dist" will install files there when it shouldn't.
1 parent 571681b commit 4153a8b

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

doc/userguide/Makefile.am

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# Don't simply use the directory "install" to include the files in
2+
# install/. That name in EXTRA_DIST triggers "make dist" to run "make
3+
# install". Which can lead to a permission denied error, or worse,
4+
# files actually installed when they shouldn't be.
15
EXTRA_DIST = \
26
_generated \
37
_static \
@@ -17,7 +21,11 @@ EXTRA_DIST = \
1721
upgrade.rst \
1822
initscripts.rst \
1923
install.rst \
20-
install \
24+
install/debian.rst \
25+
install/other.rst \
26+
install/rpm.rst \
27+
install/ubuntu.rst \
28+
install/windows.rst \
2129
ips \
2230
licenses \
2331
lua \

0 commit comments

Comments
 (0)