Skip to content

Commit 49a418d

Browse files
committed
userguide/Makefile: don't add "install" to EXTRA_DIST
Adding the directory "install" to EXTRA_DIST, actually triggers make to run "make install", which is not what we want. Instead, avoid this magic keyword and list the files in the install directory individually. If the user doesn't have permission to install files to the prefix, like "/usr", then "make dist" can fail. Worse, even they do have permission to write into the prefix, a "make dist" will install files there when it shouldn't. Ticket: OISF#8279 (cherry picked from commit 2defd5a)
1 parent 7c082f0 commit 49a418d

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

doc/userguide/Makefile.am

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# Don't simply use the directory "install" to include the files in
2+
# install/. That name in EXTRA_DIST triggers "make dist" to run "make
3+
# install". Which can lead to a permission denied error, or worse,
4+
# files actually installed when they shouldn't be.
15
EXTRA_DIST = \
26
_generated \
37
_static \
@@ -18,7 +22,11 @@ EXTRA_DIST = \
1822
upgrade.rst \
1923
initscripts.rst \
2024
install.rst \
21-
install \
25+
install/debian.rst \
26+
install/other.rst \
27+
install/rpm.rst \
28+
install/ubuntu.rst \
29+
install/windows.rst \
2230
ips \
2331
licenses \
2432
lua \

0 commit comments

Comments
 (0)