Skip to content

Commit 805ac10

Browse files
committed
rust/smb: fix manual_unwrap_or_default
warning: match can be simplified with `.unwrap_or_default()` --> src/smb/smb2.rs:682:41 | 682 | let _guid_vec = match state.ssn2vec_map.remove(&guid_key) { | _________________________________________^ 683 | | Some(p) => p, 684 | | None => { 685 | | SCLogDebug!("SMBv2 response: GUID NOT FOUND"); 686 | | Vec::new() 687 | | }, 688 | | }; | |_________________________^ help: replace it with: `state.ssn2vec_map.remove(&guid_key).unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
1 parent 8d45e8c commit 805ac10

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

rust/src/smb/smb2.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -679,13 +679,7 @@ pub fn smb2_response_record(state: &mut SMBState, r: &Smb2Record)
679679
/* search key-guid map */
680680
let guid_key = SMBCommonHdr::new(SMBHDR_TYPE_GUID,
681681
r.session_id, r.tree_id, r.message_id);
682-
let _guid_vec = match state.ssn2vec_map.remove(&guid_key) {
683-
Some(p) => p,
684-
None => {
685-
SCLogDebug!("SMBv2 response: GUID NOT FOUND");
686-
Vec::new()
687-
},
688-
};
682+
let _guid_vec = state.ssn2vec_map.remove(&guid_key).unwrap_or_default();
689683
SCLogDebug!("SMBv2 write response for GUID {:?}", _guid_vec);
690684
}
691685
_ => {

0 commit comments

Comments
 (0)