unix-socket: fix memory leak on client disconnect

victorjulien · victorjulien · commit 99fd69830ee9 · 2025-09-14T08:43:44.000+02:00
If a client loses the connection during a reload it initiated there is a small memory leak. Bug: OISF#7891. (cherry picked from commit f963c40)
diff --git a/src/unix-manager.c b/src/unix-manager.c
@@ -519,7 +519,7 @@ static int UnixCommandExecute(UnixCommand * this, char *command, UnixClient *cli
     }
 
     if (UnixCommandSendJSONToClient(client, server_msg) != 0) {
-        goto error;
+        goto error_cmd;
     }
 
     json_decref(jsoncmd);

Original file line number	Diff line number	Diff line change
`@@ -519,7 +519,7 @@ static int UnixCommandExecute(UnixCommand * this, char command, UnixClient cli`
`519`	`519`	`}`
`520`	`520`
`521`	`521`	`if (UnixCommandSendJSONToClient(client, server_msg) != 0) {`
`522`		`- goto error;`
	`522`	`+ goto error_cmd;`
`523`	`523`	`}`
`524`	`524`
`525`	`525`	`json_decref(jsoncmd);`