util/port-interval-tree: suppress cppcheck false positives

victorjulien · victorjulien · commit bd198231a051 · 2026-05-25T16:20:25.000Z
diff --git a/src/util-port-interval-tree.c b/src/util-port-interval-tree.c
@@ -38,6 +38,7 @@
  */
 static int SCPortIntervalCompareAndUpdate(const SCPortIntervalNode *a, SCPortIntervalNode *b)
 {
+    DEBUG_VALIDATE_BUG_ON(a == NULL); // help cppcheck
     if (a->port2 > b->max) {
         b->max = a->port2;
     }
@@ -48,6 +49,7 @@ static int SCPortIntervalCompareAndUpdate(const SCPortIntervalNode *a, SCPortInt
 }
 
 // cppcheck-suppress nullPointerRedundantCheck
+// cppcheck-suppress ctunullpointer
 IRB_GENERATE(PI, SCPortIntervalNode, irb, SCPortIntervalCompareAndUpdate);
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@`
`38`	`38`	`*/`
`39`	`39`	`static int SCPortIntervalCompareAndUpdate(const SCPortIntervalNode a, SCPortIntervalNode b)`
`40`	`40`	`{`
	`41`	`+ DEBUG_VALIDATE_BUG_ON(a == NULL); // help cppcheck`
`41`	`42`	`if (a->port2 > b->max) {`
`42`	`43`	`b->max = a->port2;`
`43`	`44`	`}`
`@@ -48,6 +49,7 @@ static int SCPortIntervalCompareAndUpdate(const SCPortIntervalNode *a, SCPortInt`
`48`	`49`	`}`
`49`	`50`
`50`	`51`	`// cppcheck-suppress nullPointerRedundantCheck`
	`52`	`+// cppcheck-suppress ctunullpointer`
`51`	`53`	`IRB_GENERATE(PI, SCPortIntervalNode, irb, SCPortIntervalCompareAndUpdate);`
`52`	`54`
`53`	`55`	`/**`